default initialize TrajectorySeed::dir_

[slava77]

this is following the UBSAN issue reported in #35033

138.2 step2
DataFormats/TrajectorySeed/interface/TrajectorySeed.h:44:3: runtime error: 
      load of value 10967, which is not a valid value for type 'PropagationDirection'

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35795/26159

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

• DataFormats/TrajectorySeed (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@JanFSchulte, @rovere, @VinInn, @gpetruc, @mmusich, @mtosi this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52af3e/19857/summary.html
COMMIT: 71533e0
CMSSW: CMSSW_12_1_X_2021-10-22-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35795/19857/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @Dr15Jones Use StatisticsSenderService for all framework files #35505
• @mmusich modernize DQM/TrackerCommon #35782
• @consuegs Python3 migration fix #35788
• @guitargeek Replace boost::ptr_vector and boost::ptr_list with STL collections in RecoTauTag/RecoTau #35708

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52af3e/19857/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52af3e/19857/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 2751113
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2751077
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 39 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 170 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[VinInn]

why oppositeToMomentum?

[slava77]

why oppositeToMomentum?

because its int value is 0 and that's what's the most likely "empty" memory default is.

[VinInn]

Sorry I do not find this argument convincing.
Either it is left uninitialized (and the cause fixed) or it shall be initialized to a "invalid" value eventually extending the corresponding enum

[slava77]

Either it is left uninitialized (and the cause fixed) or it shall be initialized to a "invalid" value eventually extending the corresponding enum

fair enough. I've extended the enum.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35795/26174

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #35795 was updated. @jpata, @cmsbuild, @slava77 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52af3e/19878/summary.html
COMMIT: 92f1195
CMSSW: CMSSW_12_1_X_2021-10-24-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35795/19878/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 2751113
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2751084
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 39 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 170 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #35795 92f1195

• jenkins tests pass and comparisons with the baseline show no relevant differences, which confirms that the PR is essentially technical

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1