Fixes to L2Tau CNN and deepTauID for HLT

[mbluj]

PR description:

This PR fixes critical issues found in L2NNTag modules and deepTauID for HLT. The PR contains the following changes:

• Add default values for configurable parameters where those have not been set to allow correct parsing to ConfDB;
• Allow a pass-through at L2 for all L1 taus with pt above a configurable threshold in L2NNTauTag to avoid observed drop of efficiency for taus with gen_vis_pt > 500 GeV (for gen_vis_pt < 500 GeV the algo efficiency is above 90%). We estimated that the rate with the pass-though threshold of 250 GeV (default) does not significantly change: for the 3 kHz Working Point (WP) it goes from 2999.7 Hz to 3026.4 Hz (0.9%); changes are similar for other WPs.

The changes are simple fixes and do not change behavior of the modules, but on the other hand are critical as without them L2Tau CNN and deepTauID cannot be deployed at HLT.

We plan a backport to 12_1_X as soon as this PR is accepted.

PR validation:

Standard tests passed

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[mbluj]

FYI, @azotz @kandrosov

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36009/26450

• This PR adds an extra 48KB to repository

[cmsbuild]

A new Pull Request was created by @mbluj for master.

It involves the following packages:

• RecoTauTag/HLTProducers (hlt)
• RecoTauTag/RecoTau (reconstruction)

@jpata, @missirol, @cmsbuild, @Martin-Grunewald, @slava77 can you please review it and eventually sign? Thanks.
@silviodonato, @mbluj, @azotz this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8cd36/20285/summary.html
COMMIT: f500a7a
CMSSW: CMSSW_12_2_X_2021-11-05-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36009/20285/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 2901890
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2901856
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36009/26470

• This PR adds an extra 48KB to repository

[cmsbuild]

Pull request #36009 was updated. @jpata, @missirol, @cmsbuild, @Martin-Grunewald, @slava77 can you please check and sign again.

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8cd36/20300/summary.html
COMMIT: 2c8c246
CMSSW: CMSSW_12_2_X_2021-11-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36009/20300/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 2901890
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2901862
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

[slava77]

+reconstruction

for #36009 2c8c246

• code changes are in line with the PR description: the reco category updates are only in RecoTauTag/RecoTau/plugins/DeepTauId.cc where a valid default WP is set (empty string -> "-1")
• jenkins tests pass and comparisons with the baseline show no (relevant) differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1