-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTD geometry: update ETL passive structure #36071
Conversation
… ETL mother volume
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36071/26546
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test the added code is for the time being used nowhere, no effect from this PR is therefore expected (the material description is updated just with additions). |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c7c602/20430/summary.html Comparison SummarySummary:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36071/26566
|
Pull request #36071 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c7c602/20456/summary.html Comparison SummarySummary:
|
+Upgrade This PR is to add new MTD geometry I15. It is not used yet, so no change is expected in PR test. |
Updated documentation of the final additions to this PR: |
@fabiocos It will be nice if you make presentation of MTD Geometry+SIM in the simulation meeting |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Addition of the revised description of ETL mother volume and passive structure to include the notch and the cables inside it (work by @martatornago ). This version I15 of MTD requires the recently added calo envelope O9 (added by @bsunanda in #36013 . See https://indico.cern.ch/event/1083649/contributions/4556808/attachments/2325151/3960278/ETLGeometryUpdateD86.pdf .
PR validation:
These updates have been tested privately for consistency with the engineering drawings and absence of overlaps. A screenshot from the event display:
![Schermata 2021-11-08 alle 15 49 15](https://user-images.githubusercontent.com/4058194/141101011-1b044d46-6dd9-4814-a979-44980380518c.png)
.