Remove deprecation warnings from Alignment subsystem

[mmusich]

PR description:

Title says is all. Went systematically through all CMSDEPRECATED_X warnings for Alignment subsystem.

• removed EventSetup::get() calls
• migrated away from deprecated EDModules API
• put class headers of plugins in the same file as implementation
• modernized code

Resolves cms-AlCaDB/AlCaTools#48
Part of #31061

PR validation:

cmssw compiles

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36193/26779

• This PR adds an extra 68KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Alignment/MuonAlignment/plugins/MuonGeometrySVGTemplate.cc modified in PR(s): MuonAlignment ASAN bug fix #36147
  • File Alignment/MuonAlignmentAlgorithms/plugins/CSCOverlapsBeamSplashCut.cc modified in PR(s): MuonAlignment ASAN bug fix #36147

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• Alignment/CommonAlignmentProducer (alca)
• Alignment/LaserAlignment (alca)
• Alignment/LaserAlignmentSimulation (alca)
• Alignment/MuonAlignment (alca)
• Alignment/MuonAlignmentAlgorithms (alca)
• Alignment/OfflineValidation (alca)
• Alignment/SurveyAnalysis (alca)
• Alignment/TrackerAlignment (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@pakhotin, @adewit, @abbiendi, @CeliaFernandez, @jhgoh, @tlampen, @tocheng, @mmusich, @trocino this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a624a/20641/summary.html
COMMIT: 21fcbe8
CMSSW: CMSSW_12_2_X_2021-11-20-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36193/20641/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS deprecated warnings: 6 CMS deprecated warnings found, see summary page for details.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36193/26781

• This PR adds an extra 68KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Alignment/MuonAlignment/plugins/MuonGeometrySVGTemplate.cc modified in PR(s): MuonAlignment ASAN bug fix #36147
  • File Alignment/MuonAlignmentAlgorithms/plugins/CSCOverlapsBeamSplashCut.cc modified in PR(s): MuonAlignment ASAN bug fix #36147

[cmsbuild]

Pull request #36193 was updated. @cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a624a/20645/summary.html
COMMIT: e16b9af
CMSSW: CMSSW_12_2_X_2021-11-20-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36193/20645/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3247021
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3246993
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• tests pass, diffs in MsgLogger only

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1