-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added FinalPath implementation #36398
Conversation
This is needed for the FinalPath implementation.
Consolidated all common code used by OutputModuleBase classes into one class.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36398/27201
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages:
@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36398/27211
|
Pull request #36398 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please check and sign again. |
please test |
OutputModules on FinalPaths do not cause unscheduled execution.
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36398/27245
|
Pull request #36398 was updated. @makortel, @smuzaffar, @Dr15Jones can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-436a1b/21106/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
PR description:
OutputModules placed on a FinalPath do not cause unscheduled execution. This ability was requested by HLT.
As part of work, consolidated all copied code used in various OutputModuleBase implementations into one class.
PR validation:
Code compiles. All framework related unit tests (included the newly added ones) pass.