[12.1.X] OverlapValidation: bugfix to esConsumes migration

[mmusich]

backport of #36449

PR description:

During the esConsumes migration in PR #32005 a mistake was introduced in this change (link); in the OverlapValidation::analyze scope a new local variable magField_ was introduced shadowing in its local scope a data-member variable of the same name.
This leads to a segmentation fault when trying to evaluate the magnetic field in

cmssw/TrackingTools/AnalyticalJacobians/src/JacobianLocalToCurvilinear.cc

Line 13 in ce6fe13

GlobalVector h = magField.inInverseGeV(x);

I profit of this PR to rename an internal method which had the same name as the framework one (analyze) to analyzeTrajectory.

PR validation:

Privately run the changed branch the following configuration file https://gist.github.com/mmusich/6ef7df0b448d7eab47095e5e86ce5299 (in the scope of the mkFit validation setup).

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #36449.

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_1_X.

It involves the following packages:

• Alignment/OfflineValidation (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from OverlapValidation: bugfix to esConsumes migration #36449

[mmusich]

type bug-fix

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1dfc5d/21191/summary.html
COMMIT: e5a229f
CMSSW: CMSSW_12_1_X_2021-12-10-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36451/21191/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 2901440
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2901411
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1