Add a unit test for correctionlib external #36547

nsmith- · 2021-12-17T22:51:37Z

This is a backport of #35296 which validates the backport of the correctionlib external in cmsdist cms-sw/cmsdist#7523
It provides only C++ and python 2 functionality. The correction CLI utility and python 3 bindings are omitted for now, as the intention here is only to provide legacy support for python 2 nanoAOD-tools.

This will need testing with the externals including cms-sw/cmsdist#7523

cmsbuild · 2021-12-17T22:51:58Z

A new Pull Request was created by @nsmith- (Nicholas Smith) for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/Utilities (analysis)

@cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

qliphy · 2021-12-20T00:37:52Z

test parameters:

pull_request = [10.6.X] Correctionlib C++ and python2 binding cmsdist#7523

qliphy · 2021-12-20T00:38:20Z

please test

cmsbuild · 2021-12-20T01:29:05Z

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61cd2d/21395/summary.html
COMMIT: 5bba350
CMSSW: CMSSW_10_6_X_2021-12-19-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36547/21395/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2021-12-19-0000/src/PhysicsTools/Utilities/test/testPrimitive.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2021-12-19-0000/src/PhysicsTools/Utilities/test/testIntegral.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2021-12-19-0000/src/PhysicsTools/Utilities/test/testRunner.cpp 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2021-12-19-0000/src/PhysicsTools/Utilities/test/test_correctionlib.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2021-12-19-0000/src/PhysicsTools/Utilities/test/testLumiReweight.cc 
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2021-12-19-0000/src/PhysicsTools/Utilities/test/test_correctionlib.cc:4:10: fatal error: correction.h: No such file or directory
 #include "correction.h"
          ^~~~~~~~~~~~~~
compilation terminated.
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2021-12-19-0000/src/PhysicsTools/Utilities/test/test_correctionlib.cc:4:10: fatal error: correction.h: No such file or directory
 #include "correction.h"

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

****WARNING: Invalid tool correctionlib. Please fix src/PhysicsTools/Utilities/test/BuildFile.xml file.
>> Creating project symlinks
>> Entering Package FWCore/Version
>> Entering Package PhysicsTools/Utilities
>> Compile sequence completed for CMSSW CMSSW_10_6_X_2021-12-19-0000
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2021-12-19-0000/tmp/slc7_amd64_gcc700/cache/log/src '||' 'true)'
++ scram build outputlog
Reading cached build data
Entering library rule at FWCore/Version
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2021-12-19-0000/src/FWCore/Version/src/GetReleaseVersion.cc

qliphy · 2022-01-04T01:14:00Z

please test

cmsbuild · 2022-01-04T01:43:35Z

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61cd2d/21522/summary.html
COMMIT: 5bba350
CMSSW: CMSSW_10_6_X_2022-01-02-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36547/21522/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2022-01-02-0000/src/PhysicsTools/Utilities/test/testPrimitive.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2022-01-02-0000/src/PhysicsTools/Utilities/test/testIntegral.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2022-01-02-0000/src/PhysicsTools/Utilities/test/testRunner.cpp 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2022-01-02-0000/src/PhysicsTools/Utilities/test/testLumiReweight.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2022-01-02-0000/src/PhysicsTools/Utilities/test/test_correctionlib.cc 
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2022-01-02-0000/src/PhysicsTools/Utilities/test/test_correctionlib.cc:4:10: fatal error: correction.h: No such file or directory
 #include "correction.h"
          ^~~~~~~~~~~~~~
compilation terminated.
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2022-01-02-0000/src/PhysicsTools/Utilities/test/test_correctionlib.cc:4:10: fatal error: correction.h: No such file or directory
 #include "correction.h"

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

****WARNING: Invalid tool correctionlib. Please fix src/PhysicsTools/Utilities/test/BuildFile.xml file.
>> Creating project symlinks
>> Entering Package FWCore/Version
>> Entering Package PhysicsTools/Utilities
>> Compile sequence completed for CMSSW CMSSW_10_6_X_2022-01-02-0000
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2022-01-02-0000/tmp/slc7_amd64_gcc700/cache/log/src '||' 'true)'
++ scram build outputlog
Reading cached build data
Entering library rule at FWCore/Version
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2022-01-02-0000/src/FWCore/Version/src/GetReleaseVersion.cc

smuzaffar · 2022-01-10T09:48:37Z

please test

cmsbuild · 2022-01-10T12:30:05Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61cd2d/21587/summary.html
COMMIT: 5bba350
CMSSW: CMSSW_10_6_X_2022-01-09-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36547/21587/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 3215686
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3215350
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 143 log files, 29 edm output root files, 35 DQM output files
TriggerResults: no differences found

qliphy · 2022-01-10T13:25:09Z

+1

qliphy · 2022-01-10T13:25:56Z

merge

santocch · 2022-02-17T13:11:27Z

+1

cmsbuild · 2022-02-17T13:11:43Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will be automatically merged.

Add a unit test for correctionlib external

5bba350

cmsbuild added this to the CMSSW_10_6_X milestone Dec 17, 2021

cmsbuild added the analysis-pending label Dec 17, 2021

cmsbuild added orp-pending pending-signatures tests-pending labels Dec 17, 2021

cmsbuild added the requires-external label Dec 20, 2021

cmsbuild added tests-started and removed tests-pending labels Dec 20, 2021

cmsbuild added tests-rejected and removed tests-started labels Dec 20, 2021

cmsbuild added tests-started and removed tests-rejected labels Jan 4, 2022

cmsbuild added tests-rejected and removed tests-started labels Jan 4, 2022

smuzaffar mentioned this pull request Jan 10, 2022

[10.6.X] Correctionlib C++ and python2 binding cms-sw/cmsdist#7523

Merged

cmsbuild added tests-started and removed tests-rejected labels Jan 10, 2022

cmsbuild added tests-approved and removed tests-started labels Jan 10, 2022

cmsbuild removed the orp-pending label Jan 10, 2022

cmsbuild added the orp-approved label Jan 10, 2022

cmsbuild merged commit c04fa51 into cms-sw:CMSSW_10_6_X Jan 10, 2022

cmsbuild added analysis-approved fully-signed and removed analysis-pending pending-signatures labels Feb 17, 2022

nsmith- deleted the correctionlib_backport_10_6 branch July 8, 2022 20:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a unit test for correctionlib external #36547

Add a unit test for correctionlib external #36547

nsmith- commented Dec 17, 2021

cmsbuild commented Dec 17, 2021

qliphy commented Dec 20, 2021

qliphy commented Dec 20, 2021

cmsbuild commented Dec 20, 2021

qliphy commented Jan 4, 2022

cmsbuild commented Jan 4, 2022

smuzaffar commented Jan 10, 2022

cmsbuild commented Jan 10, 2022

qliphy commented Jan 10, 2022

qliphy commented Jan 10, 2022

santocch commented Feb 17, 2022

cmsbuild commented Feb 17, 2022

Add a unit test for correctionlib external #36547

Add a unit test for correctionlib external #36547

Conversation

nsmith- commented Dec 17, 2021

cmsbuild commented Dec 17, 2021

qliphy commented Dec 20, 2021

qliphy commented Dec 20, 2021

cmsbuild commented Dec 20, 2021

Build

Clang Build

qliphy commented Jan 4, 2022

cmsbuild commented Jan 4, 2022

Build

Clang Build

smuzaffar commented Jan 10, 2022

cmsbuild commented Jan 10, 2022

Comparison Summary

qliphy commented Jan 10, 2022

qliphy commented Jan 10, 2022

santocch commented Feb 17, 2022

cmsbuild commented Feb 17, 2022