Fix to 39434.502/501

[AdrianoDee]

PR description:

Solves issue :

• Failures in workflow 39434.501 and 39434.502 since CMSSW_12_3_X_2022-01-09-0000 #36661

[AdrianoDee]

type bug-fix

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36714/27801

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

• RecoLocalTracker/SiPixelClusterizer (reconstruction)
• RecoLocalTracker/SiPixelRecHits (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@mtosi, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @OzAmram, @ferencek, @dkotlins, @gpetruc, @mmusich, @threus, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[AdrianoDee]

test parameters:

workflows = 39434.501,39434.502,39434.5

[AdrianoDee]

enable gpu

[AdrianoDee]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e2955f/21738/summary.html
COMMIT: f24c9b8
CMSSW: CMSSW_12_3_X_2022-01-14-1100/slc7_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36714/21738/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19811
• DQMHistoTests: Total failures: 2056
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 17755
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: no differences found

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e2955f/39434.501_TTbar_14TeV+2026D88_Patatrack_PixelOnlyCPU+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e2955f/39434.502_TTbar_14TeV+2026D88_Patatrack_PixelOnlyGPU+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e2955f/39434.5_TTbar_14TeV+2026D88_pixelTrackingOnly+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3461659
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3461637
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: no differences found

[perrotta]

urgent
(Thank you @AdrianoDee )

[jpata]

Are the changes observed in 11634.506 understood? Is it coming from this bugfix, or is it a known irreproducibility?

https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisonsGPU/CMSSW_12_3_X_2022-01-14-1100+e2955f/47866/validateJR/all_OldVSNew_TTbar14TeV2021pixel3GPUwf11634p506/

https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisonsGPU/CMSSW_12_3_X_2022-01-14-1100+e2955f/47866/validateJR/all_OldVSNew_TTbar14TeV2021pixel3GPUwf11634p506/all_OldVSNew_TTbar14TeV2021pixel3GPUwf11634p506c_log10recoTracks_pixelTracks__RECO_obj_p.png

[AdrianoDee]

This should be a known irreproducibility. The only module that is in common with 11634.506 is modified with the phase2 tracker procmodifier so I don't see any possible interference.

[jpata]

+reconstruction

• bugfix for Failures in workflow 39434.501 and 39434.502 since CMSSW_12_3_X_2022-01-09-0000 #36661
• no relevant reco changes

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1