Create new ECAL DQM GpuTask to monitor and compare CPU and GPU generated ECAL RECO objects #36742
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| #ifndef DQM_EcalMonitorTasks_GpuTask_H | ||
| #define DQM_EcalMonitorTasks_GpuTask_H | ||
|
|
||
| #include "DQWorkerTask.h" | ||
|
|
||
| #include "DataFormats/EcalRecHit/interface/EcalRecHitCollections.h" | ||
| #include "DataFormats/EcalDigi/interface/EcalDigiCollections.h" | ||
|
|
||
| namespace ecaldqm { | ||
|
|
||
| class GpuTask : public DQWorkerTask { | ||
| public: | ||
| GpuTask(); | ||
| ~GpuTask() override = default; | ||
|
|
||
| void addDependencies(DependencySet&) override; | ||
|
|
||
| bool filterRunType(short const*) override; | ||
|
|
||
| void beginEvent(edm::Event const&, edm::EventSetup const&, bool const&, bool&) override; | ||
| bool analyze(void const*, Collections) override; | ||
|
|
||
| template <typename DigiCollection> | ||
| void runOnCpuDigis(DigiCollection const&, Collections); | ||
| template <typename DigiCollection> | ||
| void runOnGpuDigis(DigiCollection const&, Collections); | ||
| void runOnCpuUncalibRecHits(EcalUncalibratedRecHitCollection const&, Collections); | ||
| void runOnGpuUncalibRecHits(EcalUncalibratedRecHitCollection const&, Collections); | ||
| void runOnCpuRecHits(EcalRecHitCollection const&, Collections); | ||
| void runOnGpuRecHits(EcalRecHitCollection const&, Collections); | ||
|
|
||
| private: | ||
| void setParams(edm::ParameterSet const&) override; | ||
|
|
||
| bool runGpuTask_; | ||
| bool gpuOnlyPlots_; | ||
| std::vector<int> uncalibOOTAmps_; | ||
|
|
||
| EBDigiCollection const* EBCpuDigis_; | ||
| EEDigiCollection const* EECpuDigis_; | ||
|
|
||
| EcalUncalibratedRecHitCollection const* EBCpuUncalibRecHits_; | ||
| EcalUncalibratedRecHitCollection const* EECpuUncalibRecHits_; | ||
|
|
||
| EcalRecHitCollection const* EBCpuRecHits_; | ||
| EcalRecHitCollection const* EECpuRecHits_; | ||
| }; | ||
|
|
||
| inline bool GpuTask::analyze(void const* p, Collections collection) { | ||
| switch (collection) { | ||
| case kEBCpuDigi: | ||
| if (p && runGpuTask_) | ||
| runOnCpuDigis(*static_cast<EBDigiCollection const*>(p), collection); | ||
| return runGpuTask_; | ||
| break; | ||
| case kEECpuDigi: | ||
| if (p && runGpuTask_) | ||
| runOnCpuDigis(*static_cast<EEDigiCollection const*>(p), collection); | ||
| return runGpuTask_; | ||
| break; | ||
| case kEBGpuDigi: | ||
| if (p && runGpuTask_) | ||
| runOnGpuDigis(*static_cast<EBDigiCollection const*>(p), collection); | ||
| return runGpuTask_; | ||
| break; | ||
| case kEEGpuDigi: | ||
| if (p && runGpuTask_) | ||
| runOnGpuDigis(*static_cast<EEDigiCollection const*>(p), collection); | ||
| return runGpuTask_; | ||
| break; | ||
| case kEBCpuUncalibRecHit: | ||
| case kEECpuUncalibRecHit: | ||
| if (p && runGpuTask_) | ||
| runOnCpuUncalibRecHits(*static_cast<EcalUncalibratedRecHitCollection const*>(p), collection); | ||
| return runGpuTask_; | ||
| break; | ||
| case kEBGpuUncalibRecHit: | ||
| case kEEGpuUncalibRecHit: | ||
| if (p && runGpuTask_) | ||
| runOnGpuUncalibRecHits(*static_cast<EcalUncalibratedRecHitCollection const*>(p), collection); | ||
| return runGpuTask_; | ||
| break; | ||
| case kEBCpuRecHit: | ||
| case kEECpuRecHit: | ||
| if (p && runGpuTask_) | ||
| runOnCpuRecHits(*static_cast<EcalRecHitCollection const*>(p), collection); | ||
| return runGpuTask_; | ||
| break; | ||
| case kEBGpuRecHit: | ||
| case kEEGpuRecHit: | ||
| if (p && runGpuTask_) | ||
| runOnGpuRecHits(*static_cast<EcalRecHitCollection const*>(p), collection); | ||
| return runGpuTask_; | ||
| break; | ||
| default: | ||
| break; | ||
| } | ||
|
|
||
| return false; | ||
| } | ||
|
|
||
| } // namespace ecaldqm | ||
|
|
||
| #endif | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import FWCore.ParameterSet.Config as cms | ||
|
|
||
| from DQM.EcalMonitorTasks.EcalMonitorTask_cfi import * | ||
|
|
||
| # Customization to run the CPU vs GPU comparison task if the job runs on a GPU enabled machine | ||
| from Configuration.ProcessModifiers.gpu_cff import gpu | ||
| from DQM.EcalMonitorTasks.GpuTask_cfi import ecalGpuTask | ||
|
There was a problem hiding this comment. Can you rename |
||
|
|
||
| gpu.toModify(ecalGpuTask.params, runGpuTask = cms.untracked.bool(True)) | ||
|
There was a problem hiding this comment. It seems that by setting As discussed in #35879 we should use a different modifier that is only given when the GPU vs. CPU comparison should be done. @jfernan2 does such a modifier exist already from DQM? In the issue mentioned it was proposed to call it |
||
| gpu.toModify(ecalMonitorTask.workers, func = lambda workers: workers.append("GpuTask")) | ||
| gpu.toModify(ecalMonitorTask, workerParameters = dict(GpuTask = ecalGpuTask)) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CMS code rule 2.12 says to not use single character variable names except for loop indices. Please rename
p.