Add ESModule tracking to StallMonitor

[Dr15Jones]

PR description:

• added signal postESMOduleRegistrationSignal_ to ActivityMonitor
• extended StallMonitor to track ESModules. These show up in the global transitions.

PR validation:

Code compiles. The extended unit tests succeeds. The stall file generated by the unit test was passed to the graph building script and the generated file looked correct.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36798/27946

• This PR adds an extra 52KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• FWCore/Concurrency (core)
• FWCore/Framework (core)
• FWCore/ServiceRegistry (core)
• FWCore/Services (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@makortel, @wddgit, @fwyzard this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36798/27948

• This PR adds an extra 52KB to repository

[cmsbuild]

Pull request #36798 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please check and sign again.

[makortel]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6508cd/21990/summary.html
COMMIT: 31daf17
CMSSW: CMSSW_12_3_X_2022-01-25-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36798/21990/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-tsg-storm HLT migration to 12_3_0_pre4 + HLT development #36790
• @namppl Updated PR for CorrWithOverlapRemovalCondition.cc #36758
• @AdrianoDee Extending SeedingHitSet & SeedGeneratorFromProtoTracksEDProducer #36184

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6508cd/21990/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6508cd/21990/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test TestFWCoreIntegrationStandalone had ERRORS
---> test unitTestsGroup_1 had ERRORS
---> test unitTestsGroup_4 had ERRORS
---> test testmat had ERRORS
and more ...

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3449316
• DQMHistoTests: Total failures: 14948
• DQMHistoTests: Total nulls: 222
• DQMHistoTests: Total successes: 3434124
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -6.372 KiB( 42 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): -1.062 KiB HLT/Filters
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: found differences in 6 / 42 workflows

[Dr15Jones]

All the test failures appear to be from the IB having multiple instances of the same class in multiple libraries which causes ROOT to throw our exception.

[Dr15Jones]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6508cd/22004/summary.html
COMMIT: 31daf17
CMSSW: CMSSW_12_3_X_2022-01-25-1700/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36798/22004/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test materialBudgetTrackerPlots had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3449324
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3449296
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: no differences found

[makortel]

+1

Unit test failure looks like a timeout (and unrelated, and I've seen it fail sporadically in other PRs too)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[perrotta]

merge