Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add D88 wfs to the short matrix #36833

Merged
merged 8 commits into from
Feb 2, 2022
Merged

Add D88 wfs to the short matrix #36833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
274d0b5
add D88 to short matrix
Jan 29, 2022
7f8b540
remove unused space
Jan 29, 2022
bf5fb39
add D86 back for the moment
Jan 29, 2022
3bdb59e
correct wf number
Jan 30, 2022
eb86367
update minbias for D88
Jan 30, 2022
95bb9fe
update list of 2026 wfs
Jan 30, 2022
294f89e
update list of 2026 wfs
Jan 30, 2022
2a7d29a
update short matrix list
Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Configuration/PyReleaseValidation/python/relval_2026.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,16 @@
numWFIB.extend([38234.0]) #2026D85
numWFIB.extend([38634.0]) #2026D86
numWFIB.extend([39034.0]) #2026D87
numWFIB.extend([39434.0,39434.5,39434.501,39434.502]) #2026D88, pixelTrackingOnly, Patatrack local reconstruction on CPU, Patatrack local reconstruction on GPU
numWFIB.extend([39434.0,39434.5,39434.501,39434.502,39434.911]) #2026D88, pixelTrackingOnly, Patatrack local reconstruction on CPU, Patatrack local reconstruction on GPU, DD4hep XML
numWFIB.extend([39634.99,39634.999]) #2026D88 premixing combined stage1+stage2 (ttbar+PU200, ttbar+PU50 for PR test)
numWFIB.extend([39434.21,39634.21,39634.9921]) #2026D88 prodlike, prodlike PU, prodlike premix stage1+stage2
numWFIB.extend([39834.0]) #2026D89
numWFIB.extend([40234.0]) #2026D90

#additional sample for short matrix
#CloseByPGun
numWFIB.extend([39496.0]) #CE_E_Front_120um D88
numWFIB.extend([39500.0]) #CE_H_Coarse_Scint D88

for numWF in numWFIB:
workflows[numWF] = _upgrade_workflows[numWF]
1 change: 1 addition & 0 deletions Configuration/PyReleaseValidation/python/relval_steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3464,6 +3464,7 @@ def gen2021HiMix(fragment,howMuch):
defaultDataSets['2026D49']='CMSSW_12_0_0_pre4-113X_mcRun4_realistic_v7_2026D49noPU-v'
defaultDataSets['2026D76']='CMSSW_12_0_0_pre4-113X_mcRun4_realistic_v7_2026D76noPU-v'
defaultDataSets['2026D77']='CMSSW_12_1_0_pre2-113X_mcRun4_realistic_v7_2026D77noPU-v'
#defaultDataSets['2026D88']='CMSSW_12_2_0_pre3-122X_mcRun4_realistic_v4_2026D88noPU-v1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this line commented out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I first wanted to add also premix workflow to the short matrix test as other Phase-2 defaults. However, I think it is better to include it when we have updated MinBias from the first relvals in 12_3_0_pre5. So, this line will be updated and uncomment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you need a clean PR, I can remove it for now.


puDataSets = {}
for key, value in defaultDataSets.items(): puDataSets[key+'PU'] = value
Expand Down
6 changes: 5 additions & 1 deletion Configuration/PyReleaseValidation/scripts/runTheMatrix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,11 @@ def runSelected(opt):
28234.0, #2026D60 (exercise HF nose)
35034.0, #2026D77 ttbar (2021 new baseline)
35234.999, #2026D77 ttbar premixing stage1+stage2, PU50
38634.0, #2026D86 ttbar
38634.0, #2026D86 ttbar (to be removed when migration to D88 is complete)
39434.0, #2026D88 ttbar
#39634.999, #2026D88 ttbar premixing stage1+stage2, PU50 (to disable when PU is available)
39496.0, #CE_E_Front_120um D88
39500.0, #CE_H_Coarse_Scint D88
25202.0, #2016 ttbar UP15 PU
250202.181, #2018 ttbar stage1 + stage2 premix
],
Expand Down