-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow DD4hep in D86 and D88 #36851
Allow DD4hep in D86 and D88 #36851
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36851/28079
|
A new Pull Request was created by @srimanob (Phat Srimanobhas) for master. It involves the following packages:
@cmsbuild, @perrotta, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e748f/22126/summary.html Comparison SummarySummary:
|
assign pdmv |
New categories assigned: pdmv @bbilin,@wajidalikhan,@jordan-martins,@kskovpen you have been requested to review this Pull request/Issue and eventually sign? Thanks |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
This PR is to allow to run DD4hep in D86 and D88. As mentioned in
#36849
we missed the proper config of DD4hep.
PR validation:
runTheMatrix.py --what upgrade -l 38634.911 -t 8 --wm init
gives the proper config that load
process.load('Configuration.Geometry.GeometryDD4hepExtended2026D88Reco_cff')
instead of
process.load('Configuration.StandardSequences.GeometryRecoDB_cff')
We can't trigger the DD4hep wf test in Phase-2 yet. This PR is just to allow us to run GEN-SIM properly.
if this PR is a backport please specify the original PR and why you need to backport that PR:
None