Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow DD4hep in D86 and D88 #36851

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Feb 1, 2022

PR description:

This PR is to allow to run DD4hep in D86 and D88. As mentioned in
#36849
we missed the proper config of DD4hep.

PR validation:

runTheMatrix.py --what upgrade -l 38634.911 -t 8 --wm init
gives the proper config that load
process.load('Configuration.Geometry.GeometryDD4hepExtended2026D88Reco_cff')
instead of
process.load('Configuration.StandardSequences.GeometryRecoDB_cff')

We can't trigger the DD4hep wf test in Phase-2 yet. This PR is just to allow us to run GEN-SIM properly.

if this PR is a backport please specify the original PR and why you need to backport that PR:

None

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36851/28079

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2022

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

  • Configuration/StandardSequences (operations)

@cmsbuild, @perrotta, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @lecriste, @mtosi, @ebrondol, @mmusich, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

srimanob commented Feb 1, 2022

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e748f/22126/summary.html
COMMIT: 3ee3336
CMSSW: CMSSW_12_3_X_2022-02-01-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36851/22126/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3449612
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3449584
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 42 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Feb 2, 2022

assign pdmv
(mosty to make pdmv aware of it: I imagine this can be signed easily)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2022

New categories assigned: pdmv

@bbilin,@wajidalikhan,@jordan-martins,@kskovpen you have been requested to review this Pull request/Issue and eventually sign? Thanks

@kskovpen
Copy link
Contributor

kskovpen commented Feb 2, 2022

+1

@perrotta
Copy link
Contributor

perrotta commented Feb 2, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants