Phase2-hgx306 Make a trivial change to reduce number of methods in Geometry/HGcalGeometry #37460
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37460/29157
|
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild Please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc6dda/23652/summary.html Comparison SummarySummary:
|
|
+1 |
|
+Upgrade Technical PR, no change is expected. |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
| @@ -278,7 +274,7 @@ HGCalGeometry::CornersVec HGCalGeometry::getCorners(const DetId& detid) const { | |||
| unsigned int cellIndex = indexFor(detid); | |||
| HGCalTopology::DecodedDetId id = m_topology.decode(detid); | |||
| if (cellIndex < m_cellVec2.size() && m_det == DetId::HGCalHSc) { | |||
| GlobalPoint v = getPosition(detid); | |||
| GlobalPoint v = getPosition(detid, false); | |||
There was a problem hiding this comment.
Given the default for the second parameter, explicitly adding it here was not strictly necessary. It doesn't hurt, anyhow
|
+1 |
PR description:
Make a trivial change to reduce number of methods in Geometry/HGcalGeometry as suggested by Andrea
PR validation:
Use the runTheMatrix test workflows
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special