-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable EMTF regional showers with unpacked info #37544
Enable EMTF regional showers with unpacked info #37544
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37544/29270
|
A new Pull Request was created by @zuoxunwu (Xunwu Zuo) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab613b/23891/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR might have caused the
see #37584 |
PR description:
This PR updates the config in L1T DQM for EMTF showers.
The shower DQM are developed in PR36128 and PR36396, when the unpacker for EMTF shower was not available. The unpacker has been added in PR37194.
Now the EMTF shower DQM modules are enabled with unpacked info as inputs.
PR validation:
Tested with recent cosmic data Run 349840. The workflow runs without error. The plots for EMTF showers are empty, which is expected as there is no CSC shower input for the moment and the EMTF gives an empty shower collection.
Passed unit test and matrix tests.
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A