Make sampicSubDetId a tracked parameter #38366

ChrisMisan · 2022-06-14T12:42:25Z

PR description:

This PR changes sampicSubDetId to the tracked parameter as requested in #38365

PR validation:

PR was tested with 136.8562.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This change needs to be included in the 12_4_X backport #38365 and in future backport to 12_3_X.

cmsbuild · 2022-06-14T12:49:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38366/30552

This PR adds an extra 16KB to repository

cmsbuild · 2022-06-14T12:49:54Z

A new Pull Request was created by @ChrisMisan (Christopher) for master.

It involves the following packages:

EventFilter/CTPPSRawToDigi (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabferro, @grzanka this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

perrotta · 2022-06-14T13:18:41Z

@ChrisMisan please fix also this line:
https://github.com/cms-sw/cmssw/pull/38365/files#diff-a09b55317cabd9767a93bc065dc99ecf66ffc1ed960840b62c270711e2b158beR251

cmsbuild · 2022-06-14T14:14:33Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38366/30557

ERROR: Build errors found during clang-tidy run.

CalibPPS/ESProducers/plugins/TotemDAQMappingESSourceXML.cc:251:27: error: no matching member function for call to 'getParameter' [clang-diagnostic-error]
      sampicSubDetId(conf.getParameter<unsigned int>("sampicSubDetId", 5)),
                          ^
/cvmfs/cms-ib.cern.ch/nweek-02737/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_5_X_2022-06-14-1100/src/FWCore/ParameterSet/interface/ParameterSet.h:303:26: note: candidate function template not viable: requires single argument 'name', but 2 arguments were provided
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

cmsbuild · 2022-06-14T14:39:27Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38366/30559

This PR adds an extra 20KB to repository

cmsbuild · 2022-06-14T14:39:53Z

Pull request #38366 was updated. @malbouis, @yuanchao, @clacaputo, @cmsbuild, @slava77, @jpata, @tvami, @francescobrivio can you please check and sign again.

tvami · 2022-06-14T14:42:58Z

@cmsbuild , please test

cmsbuild · 2022-06-14T15:51:56Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b79fb5/25518/summary.html
COMMIT: c299786
CMSSW: CMSSW_12_5_X_2022-06-14-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38366/25518/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

4.22

----- Begin Fatal Exception 14-Jun-2022 16:55:10 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing ESSource: class=TotemDAQMappingESSourceXML label='totemDAQMappingESSourceXML_TimingDiamond'
Exception Message:
MissingParameter: Parameter 'sampicSubDetId' not found.
----- End Fatal Exception -------------------------------------------------

138.4

----- Begin Fatal Exception 14-Jun-2022 16:55:47 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing ESSource: class=TotemDAQMappingESSourceXML label='totemDAQMappingESSourceXML_TimingDiamond'
Exception Message:
MissingParameter: Parameter 'sampicSubDetId' not found.
----- End Fatal Exception -------------------------------------------------

138.5

----- Begin Fatal Exception 14-Jun-2022 16:56:22 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing ESSource: class=TotemDAQMappingESSourceXML label='totemDAQMappingESSourceXML_TimingDiamond'
Exception Message:
MissingParameter: Parameter 'sampicSubDetId' not found.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

4.224.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log
4.64.6_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1/step2_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1.log
134.813134.813_RunCosmics2015C+RunCosmics2015C+RECOCOSDRUN2+ALCACOSDRUN2+HARVESTDCRUN2/step2_RunCosmics2015C+RunCosmics2015C+RECOCOSDRUN2+ALCACOSDRUN2+HARVESTDCRUN2.log

Expand to see more relval errors ...

AddOn Tests

hlt_mc_Fake

----- Begin Fatal Exception 14-Jun-2022 16:59:35 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing ESSource: class=TotemDAQMappingESSourceXML label='totemDAQMappingESSourceXML_TimingDiamond'
Exception Message:
MissingParameter: Parameter 'sampicSubDetId' not found.
----- End Fatal Exception -------------------------------------------------

hlt_mc_Fake1

----- Begin Fatal Exception 14-Jun-2022 16:59:35 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing ESSource: class=TotemDAQMappingESSourceXML label='totemDAQMappingESSourceXML_TimingDiamond'
Exception Message:
MissingParameter: Parameter 'sampicSubDetId' not found.
----- End Fatal Exception -------------------------------------------------

hlt_mc_Fake2

----- Begin Fatal Exception 14-Jun-2022 16:59:35 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing ESSource: class=TotemDAQMappingESSourceXML label='totemDAQMappingESSourceXML_TimingDiamond'
Exception Message:
MissingParameter: Parameter 'sampicSubDetId' not found.
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

cmsbuild · 2022-06-14T16:30:49Z

Pull request #38366 was updated. @malbouis, @yuanchao, @clacaputo, @cmsbuild, @slava77, @jpata, @tvami, @francescobrivio can you please check and sign again.

perrotta · 2022-06-14T16:32:49Z

please test

tvami · 2022-06-14T16:35:23Z

EventFilter/CTPPSRawToDigi/python/ctppsRawToDigi_cff.py

@@ -102,9 +104,9 @@

 # ---------- Totem Timing ----------
 totemDAQMappingESSourceXML_TotemTiming = cms.ESSource("TotemDAQMappingESSourceXML",
-  verbosity = cms.untracked.uint32(10),
+  verbosity = cms.untracked.uint32(0),


was this supposed to have changed?

yes, this was for the debug purposes, all of the other instances have verbosity=0.

Martin-Grunewald · 2022-06-14T18:22:13Z

fillDescriptions is documented here:
https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideConfigurationValidationAndHelp .

cmsbuild · 2022-06-14T20:20:51Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b79fb5/25524/summary.html
COMMIT: 15f36eb
CMSSW: CMSSW_12_5_X_2022-06-14-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38366/25524/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3659074
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3659050
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 208 log files, 45 edm output root files, 50 DQM output files
TriggerResults: no differences found

tvami · 2022-06-14T20:28:51Z

+alca

tests pass
I agree that the fillDescribtion should be done, but given that this PR's backport holds back the 12_4_0 creation, I'd say we do that in another PR

clacaputo · 2022-06-15T08:47:33Z

+reconstruction

pr needed for bp [12_4_X] Put sampic subdet id behind the era modifier #38365
fillDescription to be implemented for TotemDAQMappingESSourceXML in future pr
no reco changes

cmsbuild · 2022-06-15T08:47:51Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-06-15T08:55:42Z

+1

…making the parameter tracked.

cmsbuild added this to the CMSSW_12_5_X milestone Jun 14, 2022

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jun 14, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 14, 2022

ChrisMisan force-pushed the from-CMSSW_12_5_0_pre1 branch from 7c76e55 to 811ae77 Compare June 14, 2022 14:09

cmsbuild added alca-pending code-checks-pending and removed code-checks-approved labels Jun 14, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jun 14, 2022

ChrisMisan force-pushed the from-CMSSW_12_5_0_pre1 branch from 811ae77 to c299786 Compare June 14, 2022 14:33

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jun 14, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 14, 2022

cmsbuild added tests-started and removed tests-pending labels Jun 14, 2022

francescobrivio mentioned this pull request Jun 14, 2022

[12_4_X] Put sampic subdet id behind the era modifier #38365

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 14, 2022

cmsbuild added tests-started and removed tests-pending labels Jun 14, 2022

tvami reviewed Jun 14, 2022

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Jun 14, 2022

cmsbuild added alca-approved and removed alca-pending labels Jun 14, 2022

cmsbuild added fully-signed reconstruction-approved and removed reconstruction-pending pending-signatures labels Jun 15, 2022

cmsbuild added orp-approved and removed orp-pending labels Jun 15, 2022

cmsbuild merged commit 1bd431a into cms-sw:master Jun 15, 2022

ChrisMisan mentioned this pull request Jun 15, 2022

[12_3_X]Restore sampicSubDetId backward compatibility #38376

Merged

This was referenced Jun 15, 2022

[L1T] Phase-2 update phase 2 emulator sequence #38375

Closed

[DEVEL] Added alpaka build rules cms-sw/cmsdist#7936

Merged

oljemark added a commit to oljemark/cmssw that referenced this pull request Jul 4, 2022

Added dummy sampicSubDetId value for TOTEM T2, due to PR cms-sw#38366 …

1e56763

…making the parameter tracked.

oljemark added a commit to oljemark/cmssw that referenced this pull request Jul 6, 2022

Added dummy sampicSubDetId value for TOTEM T2, due to PR cms-sw#38366 …

7524a80

…making the parameter tracked.

oljemark added a commit to oljemark/cmssw that referenced this pull request Jul 7, 2022

Added dummy sampicSubDetId value for TOTEM T2, due to PR cms-sw#38366 …

dc6f4c4

…making the parameter tracked.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make sampicSubDetId a tracked parameter #38366

Make sampicSubDetId a tracked parameter #38366

ChrisMisan commented Jun 14, 2022

cmsbuild commented Jun 14, 2022

cmsbuild commented Jun 14, 2022

perrotta commented Jun 14, 2022 •

edited

Loading

cmsbuild commented Jun 14, 2022

cmsbuild commented Jun 14, 2022

cmsbuild commented Jun 14, 2022

tvami commented Jun 14, 2022

cmsbuild commented Jun 14, 2022

cmsbuild commented Jun 14, 2022

perrotta commented Jun 14, 2022

tvami Jun 14, 2022

ChrisMisan Jun 14, 2022

Martin-Grunewald commented Jun 14, 2022

cmsbuild commented Jun 14, 2022

tvami commented Jun 14, 2022

clacaputo commented Jun 15, 2022

cmsbuild commented Jun 15, 2022

perrotta commented Jun 15, 2022

Make sampicSubDetId a tracked parameter #38366

Make sampicSubDetId a tracked parameter #38366

Conversation

ChrisMisan commented Jun 14, 2022

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jun 14, 2022

cmsbuild commented Jun 14, 2022

perrotta commented Jun 14, 2022 • edited Loading

cmsbuild commented Jun 14, 2022

cmsbuild commented Jun 14, 2022

cmsbuild commented Jun 14, 2022

tvami commented Jun 14, 2022

cmsbuild commented Jun 14, 2022

RelVals

RelVals-INPUT

AddOn Tests

cmsbuild commented Jun 14, 2022

perrotta commented Jun 14, 2022

tvami Jun 14, 2022

Choose a reason for hiding this comment

ChrisMisan Jun 14, 2022

Choose a reason for hiding this comment

Martin-Grunewald commented Jun 14, 2022

cmsbuild commented Jun 14, 2022

Comparison Summary

tvami commented Jun 14, 2022

clacaputo commented Jun 15, 2022

cmsbuild commented Jun 15, 2022

perrotta commented Jun 15, 2022

perrotta commented Jun 14, 2022 •

edited

Loading