Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update L1T menu tag in MC and relval GTs #38438

Merged

Conversation

francescobrivio
Copy link
Contributor

@francescobrivio francescobrivio commented Jun 20, 2022

PR description:

This PR updates the L1T menu tag for the 12_4_X MC prouduction campaign, as requested in this CMSTalk post for Run3 MC GTs and the Run3 relval GTs used for TSG tests.
The new L1T tag is L1Menu_Collisions2022_v1_2_0_xml.

Note: The GTs run3_data_relval and run3_data also contain the SiPixelAliThresholdsHG_offline_v0 tag that was introduced in #38273, but never propagated to autoCond.

Note2: Both run3_hlt and run3_data GTs have been updated to have the same snapshot time of run3_hlt_relval and run3_data_relval, as suggested in #38438 (comment).

GT differences:

Run 3 HLT
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun3_HLT_frozen_v1/124X_dataRun3_HLT_frozen_v2

Run 3 HLT RelVals
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun3_HLT_relval_v2/124X_dataRun3_HLT_relval_v3

Run 3 data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun3_v2/124X_dataRun3_v4

Run 3 data RelVals
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun3_relval_v2/124X_dataRun3_relval_v4

2022 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_mcRun3_2022_design_v5/124X_mcRun3_2022_design_v6

2022 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_mcRun3_2022_realistic_v5/124X_mcRun3_2022_realistic_v6

2022 cosmics realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_mcRun3_2022cosmics_realistic_deco_v6/124X_mcRun3_2022cosmics_realistic_deco_v7

2022 cosmics design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_mcRun3_2022cosmics_design_deco_v5/124X_mcRun3_2022cosmics_design_deco_v6

2022 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_mcRun3_2022_realistic_HI_v5/124X_mcRun3_2022_realistic_HI_v6

2023 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_mcRun3_2023_realistic_v5/124X_mcRun3_2023_realistic_v6

2024 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_mcRun3_2024_realistic_v5/124X_mcRun3_2024_realistic_v6

Phase 2 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_mcRun4_realistic_v6/124X_mcRun4_realistic_v7

PR validation:

Tested with:
runTheMatrix.py -l 7.23,159.0,11634.0,12034.0,12434.0,12834.0 --ibeos -j16

Backport:

Not a backport, but a backport to 12_4_X will be provided

FYI: @elfontan @missirol

@francescobrivio
Copy link
Contributor Author

test parameters:

  • workflows = 7.23,159.0,11634.0,12034.0,12434.0,12834.0

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38438/30639

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@tocheng, @Martin-Grunewald, @missirol, @mmusich, @ChrisMisan, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Jun 20, 2022

@cmsbuild , please test

@tvami
Copy link
Contributor

tvami commented Jun 20, 2022

urgent

@tvami
Copy link
Contributor

tvami commented Jun 20, 2022

type l1t

@missirol
Copy link
Contributor

@francescobrivio , thanks for the update. I have one question.

The original idea of the run3_{hlt,data}_relval (as far as I understand it) was that that be identical to run3_{hlt,data} with the only exception of the L1T-menu tag; with this PR, this wouldn't be the case b/c of IOV differences (and for run3_data, also the 1 Pixel tag you mentioned in the PR description).

https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun3_HLT_frozen_v1/124X_dataRun3_HLT_relval_v3
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/124X_dataRun3_v2/124X_dataRun3_relval_v4

Would it make sense to update (the snapshots of) the run3_hlt and run3_data GTs every time the _relval GTs need to be updated with a new L1T menu?

@mmusich
Copy link
Contributor

mmusich commented Jun 20, 2022

Note: The GT 'run3_data_relval' also contains the SiPixelAliThresholdsHG_offline_v0 tag that was introduced in #38273, but never propagated to autoCond.

would you mind updating also the run3_data key? thx

@francescobrivio
Copy link
Contributor Author

@missirol @mmusich thanks for your comments, I'll implement both by the end of today.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38438/30646

  • This PR adds an extra 12KB to repository

@francescobrivio
Copy link
Contributor Author

@cmsbuild please abort

  • the last commit is wrong, i'm fixing it

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

  • last commit is now fixed

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38438/30648

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

Pull request #38438 was updated. @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

@missirol
Copy link
Contributor

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bac7a5/25650/summary.html
COMMIT: 3f2838d
CMSSW: CMSSW_12_5_X_2022-06-20-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38438/25650/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-bac7a5/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-bac7a5/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 4123805
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4123769
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
  • Checked 227 log files, 45 edm output root files, 54 DQM output files
  • TriggerResults: no differences found

@malbouis
Copy link
Contributor

+alca

  • PR according to description
  • tests results are clean (apart from the known failures not related to the changes introduced here, MessageLogger and MTD).

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 21, 2022

+1

@cmsbuild cmsbuild merged commit 1793847 into cms-sw:master Jun 21, 2022
@francescobrivio francescobrivio deleted the alca-L1Tmenu_for_MC_production branch June 21, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants