[EGM MVA ID] xml.gz to root conversion for photons

[swagata87]

PR description:

This is a follow up of #38339, which addressed xml to root conversion of electron MVA IDs, while this PR does the same for photon MVA ID. This is motivated by the noticeable improvement reported in #38339. Since the number of photon xml files are much smaller than electron, it could very well be that the improvement brought in by this PR won't be as noticeable. But I'm curious to see the effect of this PR, taking advantage of the profiling options of the bot. If the improvement is negligible, then.. oh well.

PR validation:

Tested with workflow 11834.21.

This PR is not a backport.
Backport not necessary.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38556/30794

• This PR adds an extra 16KB to repository

[swagata87]

enable profiling

[cmsbuild]

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master.

It involves the following packages:

• RecoEgamma/PhotonIdentification (reconstruction)

@jpata, @cmsbuild, @clacaputo can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @valsdav, @lgray, @sobhatta, @afiqaize, @wrtabb, @varuns23, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[swagata87]

please test with cms-data/RecoEgamma-PhotonIdentification#12

[swagata87]

type egamma

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c023c/25888/summary.html
COMMIT: 12907c9
CMSSW: CMSSW_12_5_X_2022-06-29-1100/el8_amd64_gcc10
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38556/25888/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @smuzaffar [GCC12] Silence may be used uninitialized warning #38543
• @alejands Set appropriate streamLabel for online DQM GPU validation #38527
• @yeckang [GEM] bug fix in orbit counter checker between AMC13 and GEM AMC headers #38544
• @kskovpen Update tau embed wf #38266
• @cms-sw Update tag for MagneticField-Interpolation to V01-02-00 cmsdist#7966

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c023c/25888/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c023c/25888/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3654586
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3654556
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[clacaputo]

Hi @swagata87 , I'm not sure what to check in the profiling but if I considered edm::WorkerMaker<MVAValueMapProducer<reco::Photon> >::makeModule(edm::ParameterSet const&) const, I see CPU timing reduction after this PR.

12_5_0_pre3: 2.6 % ----> this PR: 2.37 %

[swagata87]

Hi @clacaputo, thanks for checking.
I had tried to check this myself, but I was a bit lost in many folders that are produced by the PR test.
Anyways good to see some timing improvement coming from this PR, although the impact is smaller than the electron case (#38339 (comment)), as expected.

[clacaputo]

+reconstruction

• update egamma code to use root files as photon MVA ID
• pr to be merged with [EGM] xml.gz to root conversion for photons cms-data/RecoEgamma-PhotonIdentification#12
• initialization time slightly improves [EGM MVA ID] xml.gz to root conversion for photons #38556 (comment)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1