[12_4_X] Adding extra protection against invalid data to EMTF PrimitiveSelection

[eyigitba]

PR description:

During the tests of #38373 we realized that EMTF PrimitiveSelection.cc was missing protection against invalid CSC data that is enabled with Run 3 flags useRun3CCLUT_OTMB and useRun3CCLUT_TMB.

This protection is necessary for Run 3 CSC TPs when CCLUT is not running correctly at P5 which was the case before June 2022.

The slope variable is a uint16_t and it exists for Run 2 or Run 3 CSC TPs. We only use this variable if useRun3CCLUT_OTMB or useRun3CCLUT_TMB is enabled. That's why I left the max value as 65536 if these flags are disabled.

PR validation:

Validated by checking failed workflows from #38722. We see correct behaviour of rejecting these "corrupt" LCTs and it doesn't change the outcome of the correct LCTs.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #38775

[cmsbuild]

A new Pull Request was created by @eyigitba for CMSSW_12_4_X.

It involves the following packages:

• L1Trigger/L1TMuonEndCap (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@dinyar, @missirol, @thomreis, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Adding extra protection against invalid data to EMTF PrimitiveSelection #38775

[tvami]

@cmsbuild , please test

[perrotta]

backport of #38775

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cdf548/26335/summary.html
COMMIT: ccfd868
CMSSW: CMSSW_12_4_X_2022-07-19-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38794/26335/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3676198
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3676168
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1