Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] Update the EXODisappTrk skim source PD #39271

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

sam7k9621
Copy link
Contributor

@sam7k9621 sam7k9621 commented Aug 31, 2022

PR description:

This PR updates the source PD of EXODisapptrk skim which had been changed in #38919.
And it is a backport of CMSSW_12_4_X

PR validation:

None

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #39268 #38919

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 31, 2022

A new Pull Request was created by @sam7k9621 for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@cmsbuild, @bbilin, @sunilUIET, @kskovpen can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

backport of #39268

@sam7k9621
Copy link
Contributor Author

Hi @perrotta , could this also be tested, the requester needs this in the upcoming runs
thank you!

@kskovpen
Copy link
Contributor

kskovpen commented Sep 2, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f28ce/27296/summary.html
COMMIT: 366775d
CMSSW: CMSSW_12_4_X_2022-09-02-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39271/27296/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3677280
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3677244
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@kskovpen
Copy link
Contributor

kskovpen commented Sep 2, 2022

+pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@sam7k9621
Copy link
Contributor Author

Hi @perrotta , could this be merged?

@perrotta
Copy link
Contributor

perrotta commented Sep 5, 2022

+1

@cmsbuild cmsbuild merged commit 18b170b into cms-sw:CMSSW_12_4_X Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants