Fix CMS deprecation warnings in RecoEgamma subsystem

[Dr15Jones]

PR description:

• added esConsumes
• converted modules to one::EDAnalyzer

PR validation:

Packages compile without issuing a CMS deprecation warning.

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39801/32670

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoEgamma/EgammaTools/interface/BaselinePFSCRegression.h modified in PR(s): Run3-gex140 Remove 2 obsolete classes from RecoEgamma/EgammaTools #39766
  • File RecoEgamma/EgammaTools/interface/HoECalculator.h modified in PR(s): Run3-gex140 Remove 2 obsolete classes from RecoEgamma/EgammaTools #39766
  • File RecoEgamma/EgammaTools/src/BaselinePFSCRegression.cc modified in PR(s): Run3-gex140 Remove 2 obsolete classes from RecoEgamma/EgammaTools #39766
  • File RecoEgamma/EgammaTools/src/HoECalculator.cc modified in PR(s): Run3-gex140 Remove 2 obsolete classes from RecoEgamma/EgammaTools #39766

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• RecoEgamma/EgammaElectronProducers (reconstruction)
• RecoEgamma/EgammaIsolationAlgos (reconstruction)
• RecoEgamma/EgammaTools (reconstruction)

@mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @sameasy, @valsdav, @rovere, @lgray, @missirol, @sobhatta, @lecriste, @afiqaize, @wrtabb, @Prasant1993, @varuns23, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ca407/28406/summary.html
COMMIT: ac23dba
CMSSW: CMSSW_12_6_X_2022-10-20-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39801/28406/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• Reco comparison had 6 failed jobs
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3391158
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3391136
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 201 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39801/32759

• This PR adds an extra 12KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoEgamma/EgammaTools/interface/BaselinePFSCRegression.h modified in PR(s): Run3-gex140 Remove 2 obsolete classes from RecoEgamma/EgammaTools #39766
  • File RecoEgamma/EgammaTools/interface/HoECalculator.h modified in PR(s): Run3-gex140 Remove 2 obsolete classes from RecoEgamma/EgammaTools #39766
  • File RecoEgamma/EgammaTools/src/BaselinePFSCRegression.cc modified in PR(s): Run3-gex140 Remove 2 obsolete classes from RecoEgamma/EgammaTools #39766
  • File RecoEgamma/EgammaTools/src/HoECalculator.cc modified in PR(s): Run3-gex140 Remove 2 obsolete classes from RecoEgamma/EgammaTools #39766

[cmsbuild]

Pull request #39801 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again.

[clacaputo]

please test

[cmsbuild]

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ca407/28558/summary.html
COMMIT: 1d48a2a
CMSSW: CMSSW_12_6_X_2022-10-27-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39801/28558/install.sh to create a dev area with all the needed externals and cmssw changes.

This pull request cannot be automatically merged, could you please rebase it?
You can see the log for git cms-merge-topic here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ca407/28558/git-merge-result

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39801/32785

• This PR adds an extra 8KB to repository

[cmsbuild]

Pull request #39801 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again.

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ca407/28562/summary.html
COMMIT: 219def9
CMSSW: CMSSW_12_6_X_2022-10-27-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39801/28562/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @ravindkv duplicated hcalDepthTowerSumEt in GsfElectron.h #39805

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ca407/28562/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ca407/28562/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 9 differences found in the comparisons
• Reco comparison had 6 failed jobs
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3384029
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3383998
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 201 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[clacaputo]

+reconstruction

• technical PR

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1

• Technical