-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt protection against zero weights or pt for SV producer [12_4_X] #40124
Adapt protection against zero weights or pt for SV producer [12_4_X] #40124
Conversation
A new Pull Request was created by @AnnikaStein (Annika Stein) for CMSSW_12_4_X. It involves the following packages:
@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
backport of #40093 |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a39bc3/29198/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR applies the same protective measures introduced in #40081 for another producer in the
RecoBTag/SecondaryVertex
package. While we have not seen a precedent case that yields the abort signal reported in #40032 coming from this particular producer (TemplatedSecondaryVertexProducer.cc
), the logic is essentially same, so we think we should include the fixes here for safety purposes as well.PR validation:
Tests have been performed for CMSSW_12_4_10_patch3 (https://cms-sw.github.io/PRWorkflow.html)
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Meant for 12_4_X, as a backport of #40093 (we follow the same scheme for backports as for the BoostedDoubleSVProducer, just applied to TemplatedSecondaryVertexProducer to avoid abort signals in the future)
First backport: #40123