Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean unused dependencies from BuildFiles #40181

Merged
merged 1 commit into from
Dec 3, 2022
Merged

Clean unused dependencies from BuildFiles #40181

merged 1 commit into from
Dec 3, 2022

Conversation

guitargeek
Copy link
Contributor

PR description:

Another quick BuildFile cleaning PR in the style of many before (for example #39160).

In many cases, the dependencies had to be moved to the appropriate BuildFile, for example from a plugins directory to the library directory or vice versa.

This PR cleans unnecessary includes from CMSSW BuildFiles that were added in the last months.

PR validation:

CMSSW compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40181/33193

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

  • Calibration/EcalCalibAlgos (alca)
  • CondCore/PCLConfigPlugins (db)
  • DQM/CTPPS (dqm)
  • DQMOffline/CalibTracker (dqm)
  • DQMOffline/EGamma (dqm)
  • DQMOffline/JetMET (dqm)
  • DataFormats/L1TParticleFlow (upgrade, l1)
  • HLTrigger/HLTfilters (hlt)
  • JetMETCorrections/TauJet (analysis)
  • L1Trigger/L1TTrackMatch (upgrade, l1)
  • L1Trigger/Phase2L1GMT (l1)
  • L1Trigger/TrackFindingTracklet (l1)
  • L1Trigger/TrackTrigger (upgrade, l1)
  • L1Trigger/TrackerDTC (upgrade, l1)
  • L1Trigger/TrackerTFP (l1)
  • PhysicsTools/NanoAOD (xpog)
  • RecoEgamma/EgammaTools (reconstruction)
  • RecoLocalMuon/GEMRecHit (upgrade, reconstruction)
  • RecoLocalMuon/GEMSegment (upgrade, reconstruction)
  • RecoMET/METPUSubtraction (reconstruction)
  • RecoTauTag/HLTProducers (hlt)
  • RecoTracker/TransientTrackingRecHit (reconstruction)
  • Validation/HGCalValidation (dqm)
  • Validation/HLTrigger (dqm)

@Martin-Grunewald, @rekovic, @ChrisMisan, @cecilecaillol, @yuanchao, @vlimant, @ahmad3213, @cmsbuild, @missirol, @mandrenguyen, @pmandrik, @epalencia, @emanueleusai, @AdrianoDee, @jfernan2, @syuvivida, @ggovi, @micsucmed, @francescobrivio, @malbouis, @swertz, @clacaputo, @srimanob, @saumyaphor4252, @rvenditti, @tvami can you please review it and eventually sign? Thanks.
@erikbutz, @rappoccio, @gouskos, @VourMa, @felicepantaleo, @jainshilpi, @hatakeyamak, @sviret, @argiro, @Martin-Grunewald, @bsunanda, @a-kapoor, @pfs, @thomreis, @trtomei, @missirol, @threus, @varuns23, @seemasharmafnal, @jhgoh, @youyingli, @mmarionncern, @sethzenz, @apsallid, @silviodonato, @JanFSchulte, @mbluj, @lgray, @jdolen, @Prasant1993, @azotz, @simonepigazzini, @jshlee, @skinnari, @beaucero, @grzanka, @rociovilar, @vandreev11, @Sam-Harper, @fabferro, @GiacomoSguazzoni, @tocheng, @VinInn, @jdamgov, @bellan, @nhanvtran, @gkasieczka, @rovere, @schoef, @ebrondol, @mtosi, @dgulhan, @clelange, @cseez, @watson-ij, @rchatter, @valsdav, @ahinzmann, @sobhatta, @lecriste, @afiqaize, @gpetruc, @wrtabb, @mariadalfonso, @sameasy, @mmusich, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Nov 29, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13b700/29338/summary.html
COMMIT: b1d1043
CMSSW: CMSSW_13_0_X_2022-11-29-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40181/29338/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3421159
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3421128
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

+hlt

@AdrianoDee
Copy link
Contributor

+upgrade

@swertz
Copy link
Contributor

swertz commented Nov 30, 2022

+xpog

@mandrenguyen
Copy link
Contributor

+reconstruction

@ChrisMisan
Copy link
Contributor

+alca

  • no differences spotted
  • technical PR

@tvami
Copy link
Contributor

tvami commented Nov 30, 2022

+db

  • technical PR

@guitargeek
Copy link
Contributor Author

Hi @emanueleusai and @cecilecaillol, could you please take a look? This should be quick to review.

@emanueleusai
Copy link
Member

+1

  • technical PR

@tvami
Copy link
Contributor

tvami commented Dec 1, 2022

and @cecilecaillol, could you please take a look?

also @epalencia

@cecilecaillol
Copy link
Contributor

+l1

@guitargeek
Copy link
Contributor Author

Hi @rappoccio! Since only the signature of analysis is missing, can this PR be merged now? It would probably good to merge this soon, so that there are no conflicts appearing in one of the many files

@perrotta
Copy link
Contributor

perrotta commented Dec 3, 2022

+1

@perrotta
Copy link
Contributor

perrotta commented Dec 3, 2022

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment