avoid use of auto:run*_data_relval GTs in non-reHLT wfs
#40481
Merged
+72
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test parameters:
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40481/33658
|
|
A new Pull Request was created by @missirol (Marino Missiroli) for master. It involves the following packages:
@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
-1 Failed Tests: RelVals RelVals |
|
please test Re-testing. The RelVal errors reported above come from the IB, as the latter did not include #40475 yet. |
|
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
missirol
force-pushed
the
devel_fix19802
branch
from
c24a089 to
7c50f85
Compare
cmsbuild
added
code-checks-pending
operations-pending
and removed
tests-rejected
code-checks-approved
labels
|
please test This PR is ready to be reviewed (no more changes planned). Differences in wf |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-08d367/29996/summary.html Comparison SummarySummary:
|
I don't know how to find exactly the 739 new lines, but an example of additional logs is wf There are two types of messages, both caused by modifying the SKIM step to use the
[1] Post-PR |
|
@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 @cms-sw/operations-l2 Can you please review this PR? |
|
+pdmv |
|
@cms-sw/upgrade-l2 Can you please review this PR? |
|
+Upgrade |
Reducing it to a 1-line message would be appreciated (in another PR) |
|
+1 |
cmsbuild
added
fully-signed
operations-approved
orp-approved
and removed
operations-pending
pending-signatures
orp-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #19802
PR description:
This PR updates RelVal wfs to avoid using
auto:run*_data_relvalin Data wfs that do not include the L1T re-emulation and/or HLT reconstruction. In (the relevant steps of) those wfs, the appropriate GT isauto:run*_dataafaik.This change is expected to solve the issue discussed in #19802 for wfs involving the
PATstep. For further details, please see #19802 (comment).Some (not all) harvesting and skimming steps are also updated depending on whether or not they belong to
reHLTwfs (maybe updating some of these steps with--hltProcess reHLTis not strictly needed, but it is arguably clearer).As a bi-product of this PR, support for the option "hltProcess" is added to the SKIM step.
The wfs touched directly by this PR are the following:
PR validation:
Next to none.
If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:
N/A