remove duplicate plugins left by #38761 and #40264

[missirol]

PR description:

#38761 and #40264 led to the renaming of a few plugin types. The old plugin types were kept in place as duplicates at the request of HLT, to ease the renaming of these plugins in the HLT menus. After the HLT-menu updates integrated in #40641, these duplicate plugins can be removed.

Merely technical. No changes expected.

PR validation:

Tested a small number of workflows with runTheMatrix.py.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40646/33962

• This PR adds an extra 44KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelDigisClustersFromSoA.cc modified in PR(s): [RECONSTRUCTION][CLANG] Fix clang llvm14 warnings #40611
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitFromCUDA.cc modified in PR(s): New Heterogeneous Memory Pool #37952
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromCUDA.cc modified in PR(s): New Heterogeneous Memory Pool #37952
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromLegacy.cc modified in PR(s): New Heterogeneous Memory Pool #37952, Use cooperative groups to populate Associations (Histograms) in Pixel Patatrack #35713
  • File RecoLocalTracker/SiPixelRecHits/python/SiPixelRecHits_cfi.py modified in PR(s): New Heterogeneous Memory Pool #37952
  • File RecoPixelVertexing/PixelTrackFitting/plugins/PixelTrackSoAFromCUDA.cc modified in PR(s): New Heterogeneous Memory Pool #37952

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

• DQM/SiPixelHeterogeneous (dqm)
• RecoLocalTracker/SiPixelClusterizer (reconstruction)
• RecoLocalTracker/SiPixelRecHits (reconstruction)
• RecoPixelVertexing/PixelTrackFitting (reconstruction)
• RecoPixelVertexing/PixelTriplets (reconstruction)
• RecoPixelVertexing/PixelVertexFinding (reconstruction)
• RecoTracker/TkSeedGenerator (reconstruction)
• RecoTracker/TransientTrackingRecHit (reconstruction)

@micsucmed, @emanueleusai, @ahmad3213, @cmsbuild, @clacaputo, @syuvivida, @pmandrik, @mandrenguyen, @rvenditti can you please review it and eventually sign? Thanks.
@ferencek, @VourMa, @hdelanno, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @mroguljic, @gpetruc, @dkotlins, @fioriNTU, @jandrea, @mtosi, @idebruyn, @mmusich, @threus, @dgulhan, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[missirol]

@cms-sw/reconstruction-l2 @cms-sw/dqm-l2

This PR targets CMSSW_13_0_0_pre4 (in order to remove these duplicates already in 13_0_X).

I don't know if testing any extra wfs is useful, so I leave it to experts to set up and start the tests.

FYI: @cms-sw/hlt-l2

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40646/33969

• This PR adds an extra 48KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelDigisClustersFromSoA.cc modified in PR(s): [RECONSTRUCTION][CLANG] Fix clang llvm14 warnings #40611
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitFromCUDA.cc modified in PR(s): New Heterogeneous Memory Pool #37952
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromCUDA.cc modified in PR(s): New Heterogeneous Memory Pool #37952
  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitSoAFromLegacy.cc modified in PR(s): New Heterogeneous Memory Pool #37952, Use cooperative groups to populate Associations (Histograms) in Pixel Patatrack #35713
  • File RecoLocalTracker/SiPixelRecHits/python/SiPixelRecHits_cfi.py modified in PR(s): New Heterogeneous Memory Pool #37952
  • File RecoPixelVertexing/PixelTrackFitting/plugins/PixelTrackSoAFromCUDA.cc modified in PR(s): New Heterogeneous Memory Pool #37952

[cmsbuild]

Pull request #40646 was updated. @micsucmed, @emanueleusai, @ahmad3213, @cmsbuild, @clacaputo, @syuvivida, @pmandrik, @mandrenguyen, @rvenditti can you please check and sign again.

[mmusich]

test parameters:

• enable_tests = gpu
• workflows_gpu = 21034.507, 20834.507
• relvals_opt= -w upgrade
• relvals_opt_gpu = -w upgrade

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-734f9e/30281/summary.html
COMMIT: ecce942
CMSSW: CMSSW_13_0_X_2023-01-31-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40646/30281/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555495
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555467
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• You potentially added 7 lines to the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 6
• DQMHistoTests: Total histograms compared: 130207
• DQMHistoTests: Total failures: 3467
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 126740
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 5 files compared)
• Checked 20 log files, 16 edm output root files, 6 DQM output files
• TriggerResults: found differences in 3 / 5 workflows

[emanueleusai]

+1

[clacaputo]

+reconstruction

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1