Make _relval GTs symbolic and resnapshot Run3 data GTs #40692

tvami · 2023-02-04T02:01:25Z

PR description:

Discussed in https://cms-talk.web.cern.ch/t/reviewing-auto-relval-content-and-making-it-symbolic-gt/19584
We make the _relval GTs symbolic since they change less often and this way we can avoid mismatches between the GT and the GTs meant to be used with a fixed L1T menu.

We also propose to move away from using the offline (rereco) GT for data validations in the relvals, they should use the prompt GT instead (which in Run-3 is certainly almost already physics quality).

To be consistent with the relval GT, the frozen GTs were resnapshoted as well. The diff in GTs is just in the visible IOVs:

There is a lot of things using auto:run3_data
https://github.com/cms-sw/cmssw/search?p=2&q=auto%3Arun3_data
which we should probably revise, but that is beyond this PR.

PR validation:

test parameters:
  - workflows = 139.004

runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport. Given the GT names and that the current data taking release is 12_6_X, it would make sense to backport to 12_6_X

tvami · 2023-02-04T02:01:34Z

test parameters:

workflows = 139.004

tvami · 2023-02-04T02:03:11Z

@sunilUIET are the relvals at pre-releases taking a wf number from CMSSW, or does that run through some other system?

cmsbuild · 2023-02-04T02:11:28Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40692/34052

This PR adds an extra 56KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Custom Run 3 PFScouting NanoAOD #40438, Use --beamspot Nominal2022PbPbCollision for all Run 3 heavy-ion workflows #40653, The Lorentz Angle Prompt Calibration Loop for Pixel Forward Phase 1 detector #40664

cmsbuild · 2023-02-04T02:11:48Z

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

Configuration/AlCa (alca)
Configuration/HLT (hlt)
Configuration/PyReleaseValidation (pdmv, upgrade)

@malbouis, @yuanchao, @AdrianoDee, @bbilin, @Martin-Grunewald, @cmsbuild, @missirol, @srimanob, @saumyaphor4252, @kskovpen, @sunilUIET, @tvami, @ChrisMisan, @francescobrivio can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @silviodonato, @tocheng, @mmusich, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

tvami · 2023-02-04T02:12:06Z

@cmsbuild , please test

cmsbuild · 2023-02-04T03:42:12Z

-1

Failed Tests: RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-124270/30395/summary.html
COMMIT: 6caf451
CMSSW: CMSSW_13_0_X_2023-02-03-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40692/30395/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

136.731

----- Begin Fatal Exception 04-Feb-2023 03:41:20 CET-----------------------
An exception of category 'ConditionDatabase' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing ESSource: class=PoolDBESSource label='GlobalTag'
Exception Message:
Tag "L1Menu_Collisions2015_25nsStage1_v5L" has not been found in the database. from IOVProxy::load 
----- End Fatal Exception -------------------------------------------------

136.88811

----- Begin Fatal Exception 04-Feb-2023 03:41:45 CET-----------------------
An exception of category 'ConditionDatabase' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing ESSource: class=PoolDBESSource label='GlobalTag'
Exception Message:
Tag "L1Menu_Collisions2015_25nsStage1_v5L" has not been found in the database. from IOVProxy::load 
----- End Fatal Exception -------------------------------------------------

136.8311

----- Begin Fatal Exception 04-Feb-2023 03:41:45 CET-----------------------
An exception of category 'ConditionDatabase' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing ESSource: class=PoolDBESSource label='GlobalTag'
Exception Message:
Tag "L1Menu_Collisions2015_25nsStage1_v5L" has not been found in the database. from IOVProxy::load 
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

136.7611

AddOn Tests

hlt_mc_GRun

----- Begin Fatal Exception 04-Feb-2023 03:41:58 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02770/el8_amd64_gcc11/cms/cmssw/CMSSW_13_0_X_2023-02-03-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py
Exception Message:
 unknown python problem occurred.
AttributeError: 'tuple' object has no attribute 'split'

At:
  /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40692/30395/CMSSW_13_0_X_2023-02-03-1100/src/Configuration/AlCa/python/GlobalTag.py(99): GlobalTag
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02770/el8_amd64_gcc11/cms/cmssw/CMSSW_13_0_X_2023-02-03-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py(87664): <module>

----- End Fatal Exception -------------------------------------------------

hlt_mc_HIon

----- Begin Fatal Exception 04-Feb-2023 03:41:55 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02770/el8_amd64_gcc11/cms/cmssw/CMSSW_13_0_X_2023-02-03-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py
Exception Message:
 unknown python problem occurred.
AttributeError: 'tuple' object has no attribute 'split'

At:
  /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40692/30395/CMSSW_13_0_X_2023-02-03-1100/src/Configuration/AlCa/python/GlobalTag.py(99): GlobalTag
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02770/el8_amd64_gcc11/cms/cmssw/CMSSW_13_0_X_2023-02-03-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py(26884): <module>

----- End Fatal Exception -------------------------------------------------

hlt_mc_PIon

----- Begin Fatal Exception 04-Feb-2023 03:42:04 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02770/el8_amd64_gcc11/cms/cmssw/CMSSW_13_0_X_2023-02-03-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py
Exception Message:
 unknown python problem occurred.
AttributeError: 'tuple' object has no attribute 'split'

At:
  /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40692/30395/CMSSW_13_0_X_2023-02-03-1100/src/Configuration/AlCa/python/GlobalTag.py(99): GlobalTag
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02770/el8_amd64_gcc11/cms/cmssw/CMSSW_13_0_X_2023-02-03-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py(5283): <module>

----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

sunilUIET · 2023-02-04T06:50:27Z

Hi @tvami , as far as I understand so far, WF numbers are coming from CMSSW as defined in relval_standard/upgrade.py. If there are some hidden steps, I let @kskovpen comment.

missirol · 2023-02-04T07:50:48Z

@tvami

I guess L1Menu_Collisions2015_25nsStage1_v5L is just a typo (it's L1Menu_Collisions2015_25nsStage1_v5).

In order to make the addOnTests work, please update autoCondHLT.py as follows:

git checkout CMSSW_13_0_0_pre3 "${CMSSW_BASE}"/src/Configuration/HLT/python/autoCondHLT.py
sed -i "s|_relval'|'       |g" "${CMSSW_BASE}"/src/Configuration/HLT/python/autoCondHLT.py
sed -i "s|run1_hlt'       |run1_hlt_relval'|g" "${CMSSW_BASE}"/src/Configuration/HLT/python/autoCondHLT.py
sed -i "s|run2_hlt'       |run2_hlt_relval'|g" "${CMSSW_BASE}"/src/Configuration/HLT/python/autoCondHLT.py

Additional questions:

Why isn't run2_hlt_relval made 'symbolic' as well?
Is run1_hlt_relval only used in autoCondHLT.py#L44? If so, and if it is okay with AlCa, you could remove run1_hlt_relval from autoCond.py, and change run1_hlt_relval to run2_hlt_relval in autoCondHLT.py (or to run2_hlt if that is added to make run2_hlt_relval 'symbolic').

tvami · 2023-02-06T16:19:01Z

hi @missirol , thanks for your comments,

sed -i "s|_relval'|' |g" "${CMSSW_BASE}"/src/Configuration/HLT/python/autoCondHLT.py

is this really intended? There is no run3_hlt_relval like this

Why isn't run2_hlt_relval made 'symbolic' as well?

Because there is no run2_hlt key. I can make it tho.

If so, and if it is okay with AlCa, you could remove run1_hlt_relval from autoCond.py

ok I'll do that too

missirol · 2023-02-06T16:39:25Z

is this really intended? There is no run3_hlt_relval like this

Yes, that is the idea. What autoCondHLT.py effectively does is to customise the GT "X" with a fixed L1T menu decided by TSG, so "X" can just be run3_hlt as long as the difference between run3_hlt and run3_hlt_relval is only the L1T-menu tag.

The other questions hint at the fact that, if some updates are done upstream (e.g. adding run2_hlt), we could remove all mentions of _relval in autoCondHLT.py. (not saying it's a big gain, it just seems clearer to me that way)

missirol · 2023-02-07T06:53:33Z

+hlt

kskovpen · 2023-02-07T06:55:00Z

+pdmv

AdrianoDee · 2023-02-07T08:42:16Z

+1

Configuration/AlCa/python/autoCondModifiers.py

francescobrivio · 2023-02-07T12:53:05Z

+alca

after private discussion with @cms-sw/alca-l2 and given the urgency (we would like to have this in pre4) we decided that the cleanup of the unwanted symbolic GTs can be done later (see Clean unwanted relval symbolic GTs cms-AlCaDB/AlCaTools#85 opened as reminder). Also, given the fact that these symbolic GTs should be explicitly called somewhere (and they aren't) they remain totally harmless.

cmsbuild · 2023-02-07T12:53:30Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2023-02-07T13:18:15Z

"auto:run2_data_relval" is still needed by

Configuration/PyReleaseValidation/python/relval_steps.py
CalibTracker/SiPixelQuality/test/step3_SiPixelCalZeroBias_RAW2DIGI_RECO_ALCA.py

tvami · 2023-02-07T13:22:08Z

@perrotta that's fine, we are still providing auto:run2_data_relval, just in a different way. The wf 139.004 is also usig a _relval GT, and as you can see it runs just fine.

perrotta · 2023-02-07T13:23:50Z

+1

cmsbuild added this to the CMSSW_13_0_X milestone Feb 4, 2023

cmsbuild added hlt-pending alca-pending pending-signatures tests-pending orp-pending pdmv-pending upgrade-pending code-checks-pending labels Feb 4, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 4, 2023

cmsbuild added tests-started and removed tests-pending labels Feb 4, 2023

cmsbuild added tests-rejected and removed tests-started labels Feb 4, 2023

cmsbuild mentioned this pull request Feb 6, 2023

The Lorentz Angle Prompt Calibration Loop for Pixel Forward Phase 1 detector #40664

Merged

tvami force-pushed the SymbolicRelvalGTs branch from 6caf451 to e9139db Compare February 6, 2023 16:46

cmsbuild added tests-pending and removed tests-rejected code-checks-approved labels Feb 6, 2023

cmsbuild added tests-approved and removed tests-started labels Feb 7, 2023

cmsbuild added hlt-approved and removed hlt-pending labels Feb 7, 2023

cmsbuild added pdmv-approved and removed pdmv-pending labels Feb 7, 2023

cmsbuild added upgrade-approved and removed upgrade-pending labels Feb 7, 2023

francescobrivio reviewed Feb 7, 2023

View reviewed changes

Configuration/AlCa/python/autoCondModifiers.py Show resolved Hide resolved

Configuration/AlCa/python/autoCondModifiers.py Show resolved Hide resolved

francescobrivio mentioned this pull request Feb 7, 2023

Clean unwanted relval symbolic GTs cms-AlCaDB/AlCaTools#85

Open

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Feb 7, 2023

cmsbuild added orp-approved and removed orp-pending labels Feb 7, 2023

cmsbuild merged commit 464b909 into cms-sw:master Feb 7, 2023

sunilUIET mentioned this pull request Mar 17, 2023

reverting back to run3_data_relval for making rereco GT default in relval [13_1_X] #41077

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make _relval GTs symbolic and resnapshot Run3 data GTs #40692

Make _relval GTs symbolic and resnapshot Run3 data GTs #40692

tvami commented Feb 4, 2023 •

edited

Loading

tvami commented Feb 4, 2023

tvami commented Feb 4, 2023

cmsbuild commented Feb 4, 2023

cmsbuild commented Feb 4, 2023

tvami commented Feb 4, 2023

cmsbuild commented Feb 4, 2023

sunilUIET commented Feb 4, 2023

missirol commented Feb 4, 2023 •

edited

Loading

tvami commented Feb 6, 2023 •

edited

Loading

missirol commented Feb 6, 2023

missirol commented Feb 7, 2023

kskovpen commented Feb 7, 2023

AdrianoDee commented Feb 7, 2023

francescobrivio commented Feb 7, 2023

cmsbuild commented Feb 7, 2023

perrotta commented Feb 7, 2023

tvami commented Feb 7, 2023

perrotta commented Feb 7, 2023

Make _relval GTs symbolic and resnapshot Run3 data GTs #40692

Make _relval GTs symbolic and resnapshot Run3 data GTs #40692

Conversation

tvami commented Feb 4, 2023 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

tvami commented Feb 4, 2023

tvami commented Feb 4, 2023

cmsbuild commented Feb 4, 2023

cmsbuild commented Feb 4, 2023

tvami commented Feb 4, 2023

cmsbuild commented Feb 4, 2023

RelVals

AddOn Tests

sunilUIET commented Feb 4, 2023

missirol commented Feb 4, 2023 • edited Loading

tvami commented Feb 6, 2023 • edited Loading

missirol commented Feb 6, 2023

missirol commented Feb 7, 2023

kskovpen commented Feb 7, 2023

AdrianoDee commented Feb 7, 2023

francescobrivio commented Feb 7, 2023

cmsbuild commented Feb 7, 2023

perrotta commented Feb 7, 2023

tvami commented Feb 7, 2023

perrotta commented Feb 7, 2023

tvami commented Feb 4, 2023 •

edited

Loading

missirol commented Feb 4, 2023 •

edited

Loading

tvami commented Feb 6, 2023 •

edited

Loading