Update PPS HPTDC PCL for additional station

[ChrisMisan]

PR description:

Remove conditions restricting PCL to one station.

PR validation:

wfs 1041,1044

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

not a backport

[ChrisMisan]

type ctpps

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40696/34060

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @ChrisMisan (Christopher) for master.

It involves the following packages:

• CalibPPS/TimingCalibration (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@fabferro, @mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[ChrisMisan]

test parameters:

• workflows=1041, 1044

[ChrisMisan]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6d9bef/30410/summary.html
COMMIT: 5b4e84c
CMSSW: CMSSW_13_0_X_2023-02-05-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40696/30410/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 115 lines to the logs
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3556097
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3556075
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 41527.828 KiB( 50 files compared)
• DQMHistoSizes: changed ( 1044.0 ): 41527.828 KiB AlCaReco/PPSTimingCalibrationPCL
• Checked 221 log files, 166 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[tvami]

@ChrisMisan I'm confused to not see differences in 1041, 1044. Is that bc the input data only had one station enabled? If yes, is there any data that would be more relevant to be used in testing?

[ChrisMisan]

@ChrisMisan I'm confused to not see differences in 1041, 1044. Is that bc the input data only had one station enabled? If yes, is there any data that would be more relevant to be used in testing?

@tvami We have input only for one station, this is the reason we can't see any changes in 1041 and 1044. At this point I don't think we have any suitabe data to do the test but I believe current wfs proved that this change didn't cause any difference in the one station workflow.

[tvami]

+alca

• tests pass, no diffs, explonation here Update PPS HPTDC PCL for additional station #40696 (comment)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1