Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved PFClusterProducer from beginLuminosityBlock to beginRun #40717

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

jsamudio
Copy link
Contributor

@jsamudio jsamudio commented Feb 7, 2023

PR description:

This is a follow-up to #33652. Functions in PFClusterProducer were sectioned by luminosity block, but this was unnecessary so a change was made to section by run.

PR validation:

runTheMatrix.py -l limited -i all --ibeos performed and passed

Additionally performed PF specific validation

@hatakeyamak @juska @kdlong

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2023

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40717/34113

  • This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40717/34114

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2023

A new Pull Request was created by @jsamudio for master.

It involves the following packages:

  • RecoParticleFlow/PFClusterProducer (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@mmarionncern, @sameasy, @rchatter, @felicepantaleo, @rovere, @lgray, @missirol, @thomreis, @hatakeyamak, @simonepigazzini, @ebrondol, @argiro, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Feb 8, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43567f/30490/summary.html
COMMIT: 896fff0
CMSSW: CMSSW_13_0_X_2023-02-07-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40717/30490/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 14 lines to the logs
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555852
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555827
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

type pf

@cmsbuild cmsbuild added the pf label Feb 8, 2023
@mandrenguyen
Copy link
Contributor

+reconstruction
Simply calls an ESProducer less frequently.
No changes to comparisons, as expected.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants