-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TkAl] Further fixes to JetHT Validation #40722
Conversation
type bug-fix |
urgent
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40722/34122
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+alca
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2b976/30501/summary.html Comparison SummarySummary:
|
+1 |
PR description:
This PR fixes another couple of bugs reported by @jusaviin in the context of running the JetHT validation (see report at the Tracker Alignment meeting of 7th of Feb 2023).
These were mostly related to plotting:
JDrawer
to segfault.cms-data
(following Large files used by new All-in-one Tool cms-data/Alignment-OfflineValidation#3)cfi
files in tracker alignment all-in-one validation tool #40695 when including the auto-generated cfiPR validation:
Relies on the existing (and augmented) unit tests:
scram b runtests_JetHTall
.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A