[13.0.X] Move RecoPixelVertexing subsystems to RecoTracker

[mmusich]

backport of #41058

PR description:

Moved all RecoPixelVertexing subsystems to RecoTracker:

• RecoPixelVertexing/Configuration → RecoTracker/Configuration
• RecoPixelVertexing/PixelTrackFitting → RecoTracker/PixelTrackFitting
• RecoPixelVertexing/PixelTriplets → RecoTracker/PixelSeeding
• RecoPixelVertexing/PixelLowPtUtilities → RecoTracker/PixelLowPtUtilities
• RecoPixelVertexing/PixelVertexFinding → RecoTracker/PixelVertexFinding

Technical, no regressions expected.

PR validation:

Run successfully:

• standard limited matrix: runTheMatrix.py -l limited --ibeos
• addOnTests.py

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #41058

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_0_X.

It involves the following packages:

• CalibTracker/Configuration (alca)
• Calibration/HcalIsolatedTrackReco (alca)
• Configuration/EventContent (operations)
• Configuration/PyReleaseValidation (pdmv, upgrade)
• Configuration/StandardSequences (operations)
• DQM/Integration (dqm)
• DQM/SiPixelPhase1Config (dqm)
• DQM/SiPixelPhase1Track (dqm)
• DQM/SiStripMonitorClient (dqm)
• DQMOffline/Trigger (dqm)
• FastSimulation/Tracking (fastsim)
• HLTrigger/Configuration (hlt)
• RecoHI/HiMuonAlgos (reconstruction)
• RecoHI/HiTracking (reconstruction)
• RecoMuon/TrackerSeedGenerator (reconstruction)
• RecoPixelVertexing/Configuration (reconstruction)
• RecoPixelVertexing/PixelLowPtUtilities (reconstruction)
• RecoPixelVertexing/PixelTrackFitting (reconstruction)
• RecoPixelVertexing/PixelTriplets (reconstruction)
• RecoPixelVertexing/PixelVertexFinding (reconstruction)
• RecoTauTag/HLTProducers (hlt)
• RecoTracker/Configuration (reconstruction)
• RecoTracker/IterativeTracking (reconstruction)
• RecoTracker/PixelLowPtUtilities (reconstruction)
• RecoTracker/PixelSeeding (reconstruction)
• RecoTracker/PixelTrackFitting (reconstruction)
• RecoTracker/PixelVertexFinding (reconstruction)
• RecoTracker/SpecialSeedGenerators (reconstruction)
• RecoTracker/TkSeedGenerator (reconstruction)
• Validation/RecoTrack (dqm)

@rappoccio, @syuvivida, @bbilin, @pmandrik, @Martin-Grunewald, @perrotta, @civanch, @cmsbuild, @missirol, @mandrenguyen, @davidlange6, @emanueleusai, @mdhildreth, @AdrianoDee, @kskovpen, @sbein, @micsucmed, @fabiocos, @francescobrivio, @ssekmen, @clacaputo, @srimanob, @saumyaphor4252, @sunilUIET, @tvami, @rvenditti can you please review it and eventually sign? Thanks.
@echabert, @VourMa, @felicepantaleo, @abbiendi, @robervalwalsh, @CeliaFernandez, @MiheeJo, @Martin-Grunewald, @bsunanda, @Fedespring, @mbluj, @threus, @mmusich, @cericeci, @venturia, @hdelanno, @battibass, @makortel, @andrea21z, @SohamBhattacharya, @JanFSchulte, @jhgoh, @dgulhan, @missirol, @HuguesBrun, @azotz, @slomeo, @rociovilar, @trocino, @beaucero, @kpedro88, @yetkinyilmaz, @sroychow, @GiacomoSguazzoni, @tocheng, @VinInn, @bellan, @rovere, @jandrea, @idebruyn, @ebrondol, @mtosi, @fabiocos, @francescobrivio, @arossi83, @batinkov, @mandrenguyen, @gbenelli, @jazzitup, @silviodonato, @yenjie, @wmtford, @kurtejung, @gpetruc, @matt-komm, @sameasy, @fioriNTU this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Move RecoPixelVertexing subsystems to RecoTracker #41058

[perrotta]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33b7df/31682/summary.html
COMMIT: ada54dd
CMSSW: CMSSW_13_0_X_2023-03-29-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41223/31682/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1202 lines to the logs
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3554479
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3554451
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

+1

[civanch]

+1

[AdrianoDee]

+upgrade

[emanueleusai]

+1

[perrotta]

hold

• This will of corse not be backported, unless strictly needed by a (possible future) backport of the porting of pixel tracks to Alpaka, see e.g. Porting Pixel Tracks to Alpaka [Not to Merge]  #41117

[cmsbuild]

Pull request has been put on hold by @perrotta
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[fwyzard]

hold

* This will of corse not be backported, unless strictly needed by a (possible future) backport of the porting of pixel tracks to Alpaka, see e.g. [[WIP] Porting Pixel Tracks to Alpaka #41117](https://github.com/cms-sw/cmssw/pull/41117)

OK, though this is the opposite of what was said during the ORP two weeks ago.

Otherwise I would have asked not to merge #41058 in the first place.

At this point, I guess we have to see how best to proceed with the Alpaka developments and backport.

[perrotta]

OK, though this is the opposite of what was said during the ORP two weeks ago.

At the ORP it was decided that this PR will only get backported if needed by a contemporary backport of the porting of pixel tracks to Alpaka, which is what is written in the entry you are referring to. The PRs with those portings are still under development in the master, let conclude their iter over there before deciding what to backport and how to do it.

[mmusich]

what about
RecoPixelVertexing/PixelVertexFinding => RecoVertex/PixelVertexFinding
?

I am ready to submit a PR to master that does it.

Shall I wait for the alpaka migration to complete in master?

[AdrianoDee]

what about
RecoPixelVertexing/PixelVertexFinding => RecoVertex/PixelVertexFinding
?

I am ready to submit a PR to master that does it.

Shall I wait for the alpaka migration to complete in master?

I would wait yes ( :

[perrotta]

Clearly this PR does not need to be backported to 13_0_X any more, see #41223 (comment)

[mmusich]

Coming back to this very old thread:

I am ready to submit a PR to master that does it.
Shall I wait for the alpaka migration to complete in master?

now that the alpaka migration is done, I guess we could finally go ahead and do it. I am not sure if to target already 14_1_X or let it for 14_2_X (probably 14_2_X sounds better to avoid complications with the HI data-taking preps).

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33b7df/40847/summary.html
COMMIT: ada54dd
CMSSW: CMSSW_13_0_X_2024-08-04-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41223/40847/install.sh to create a dev area with all the needed externals and cmssw changes.

This pull request cannot be automatically merged, could you please rebase it?
You can see the log for git cms-merge-topic here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33b7df/40847/git-merge-result

[fwyzard]

I agree it would be safer to do it early in 14_2_X.

[mmusich]

I agree it would be safer to do it early in 14_2_X.

Here it is: #45842