MC truth classes renaming #41315

civanch · 2023-04-11T12:18:23Z

PR description:

Historically some classes used at SIM step have names started from "G4". It is incorrect, because it is the namespace of the Geant4 toolkit. In this PR several classes are renamed in order to have better correspondence between perpose of these clases used for MC truth handling within SIM step. Regression is expected, should be no change of any result.

PR validation:

private

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: NO

civanch · 2023-04-11T12:19:47Z

FYI, @fabiocos , @bsunanda

cmsbuild · 2023-04-11T12:25:01Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41315/35128

This PR adds an extra 44KB to repository

cmsbuild · 2023-04-11T12:25:30Z

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4Core/Application (simulation)
SimG4Core/KillSecondaries (simulation)
SimG4Core/Notification (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @bsunanda, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

civanch · 2023-04-11T12:25:56Z

please test

cmsbuild · 2023-04-11T12:39:29Z

-1

Failed Tests: Build HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d7d94a/31908/summary.html
COMMIT: e890a23
CMSSW: CMSSW_13_1_X_2023-04-11-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41315/31908/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-04-11-1100/src/SimG4Core/Application/src/CMSSimEventManager.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-04-11-1100/src/SimG4Core/Application/src/CustomUIsessionThreadPrefix.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-04-11-1100/src/SimG4Core/Application/src/CMSGDMLWriteStructure.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-04-11-1100/src/SimG4Core/Application/interface/EventAction.h:6,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-04-11-1100/src/SimG4Core/Application/src/CMSSimEventManager.cc:3:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-04-11-1100/poison/SimG4Core/Notification/interface/G4SimEvent.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
    1 | #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
      |  ^~~~~
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-04-11-1100/src/SimG4Core/Application/src/CustomUIsessionToFile.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-04-11-1100/src/SimG4Core/Application/src/ElectronLimiter.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-04-11-1100/src/SimG4Core/Application/src/EventAction.cc

cmsbuild · 2023-04-11T16:21:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41315/35131

This PR adds an extra 12KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File SimG4Core/Application/src/StackingAction.cc modified in PR(s): MTD simulation: update Track ID stored in MTD SimHits #41318
- File SimG4Core/Notification/interface/NewTrackAction.h modified in PR(s): MTD simulation: update Track ID stored in MTD SimHits #41318
- File SimG4Core/Notification/interface/TrackInformation.h modified in PR(s): MTD simulation: update Track ID stored in MTD SimHits #41318
- File SimG4Core/Notification/src/NewTrackAction.cc modified in PR(s): MTD simulation: update Track ID stored in MTD SimHits #41318
- File SimG4Core/Notification/src/SimTrackManager.cc modified in PR(s): MTD simulation: update Track ID stored in MTD SimHits #41318

cmsbuild · 2023-04-11T16:21:41Z

Pull request #41315 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

iarspider · 2023-04-11T16:22:53Z

please test

cmsbuild · 2023-04-11T16:37:24Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d7d94a/31915/summary.html
COMMIT: 4ffbc82
CMSSW: CMSSW_13_1_X_2023-04-11-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41315/31915/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-04-11-1100/src/SimG4Core/Application/src/StackingAction.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-04-11-1100/src/SimG4Core/Application/src/ThreadHandoff.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-04-11-1100/src/SimG4Core/Application/src/TrackingAction.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-04-11-1100/src/SimG4Core/Application/src/SteppingAction.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-04-11-1100/src/SimG4Core/Application/src/TrackingAction.cc:3:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-04-11-1100/poison/SimG4Core/Notification/interface/NewTrackAction.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
    1 | #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
      |  ^~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-04-11-1100/src/SimG4Core/Application/src/RunManagerMT.cc:17:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-04-11-1100/poison/SimG4Core/Notification/interface/G4SimEvent.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
    1 | #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.

cmsbuild · 2023-04-12T09:53:02Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41315/35138

This PR adds an extra 48KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File SimG4Core/Application/src/StackingAction.cc modified in PR(s): MTD simulation: update Track ID stored in MTD SimHits #41318
- File SimG4Core/Application/src/TrackingAction.cc modified in PR(s): MTD simulation: update Track ID stored in MTD SimHits #41318
- File SimG4Core/Notification/interface/NewTrackAction.h modified in PR(s): MTD simulation: update Track ID stored in MTD SimHits #41318
- File SimG4Core/Notification/interface/TrackInformation.h modified in PR(s): MTD simulation: update Track ID stored in MTD SimHits #41318
- File SimG4Core/Notification/src/NewTrackAction.cc modified in PR(s): MTD simulation: update Track ID stored in MTD SimHits #41318
- File SimG4Core/Notification/src/SimTrackManager.cc modified in PR(s): MTD simulation: update Track ID stored in MTD SimHits #41318

cmsbuild · 2023-04-12T09:53:26Z

Pull request #41315 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

civanch · 2023-04-12T09:53:54Z

please test

cmsbuild · 2023-04-12T12:59:47Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d7d94a/31935/summary.html
COMMIT: 701bfa2
CMSSW: CMSSW_13_1_X_2023-04-11-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41315/31935/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 3 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3459609
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3459587
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

fabiocos · 2023-04-13T15:47:30Z

SimG4Core/Notification/src/MCTruthUtil.cc

+  if (motherInfo->hasCastorHit()) {
+    trkInfo->setCastorHitPID(motherInfo->getCastorHitPID());
+  }
+


@civanch as far as I can see, this is basically a renaming of NewTrackAction. My recent addition for BTL should be plugged here

civanch · 2023-04-18T19:30:12Z

This PR is closed and substituted by #41370

civanch added 3 commits April 11, 2023 14:02

renamed classes

71eeea0

rename classes for MC truth

69c909b

code format

e890a23

cmsbuild added this to the CMSSW_13_1_X milestone Apr 11, 2023

cmsbuild added simulation-pending pending-signatures tests-pending orp-pending code-checks-pending labels Apr 11, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 11, 2023

cmsbuild added tests-started and removed tests-pending labels Apr 11, 2023

cmsbuild added tests-rejected and removed tests-started labels Apr 11, 2023

cmsbuild mentioned this pull request Apr 11, 2023

MTD simulation: update Track ID stored in MTD SimHits #41318

Merged

fixed compilation problem

4ffbc82

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Apr 11, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 11, 2023

cmsbuild added tests-started and removed tests-pending labels Apr 11, 2023

cmsbuild added tests-rejected and removed tests-started labels Apr 11, 2023

removed obsolete headers

701bfa2

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Apr 12, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 12, 2023

cmsbuild added tests-started and removed tests-pending labels Apr 12, 2023

cmsbuild added tests-approved and removed tests-started labels Apr 12, 2023

fabiocos reviewed Apr 13, 2023

View reviewed changes

cmsbuild mentioned this pull request Apr 16, 2023

Pixel Alpaka Migration: AlpakaInterface Updates [II] #41284

Closed

civanch mentioned this pull request Apr 18, 2023

[SIM] MCtruth cleanup #41370

Merged

civanch closed this Apr 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MC truth classes renaming #41315

MC truth classes renaming #41315

civanch commented Apr 11, 2023

civanch commented Apr 11, 2023

cmsbuild commented Apr 11, 2023

cmsbuild commented Apr 11, 2023

civanch commented Apr 11, 2023

cmsbuild commented Apr 11, 2023

cmsbuild commented Apr 11, 2023

cmsbuild commented Apr 11, 2023

iarspider commented Apr 11, 2023

cmsbuild commented Apr 11, 2023

cmsbuild commented Apr 12, 2023

cmsbuild commented Apr 12, 2023

civanch commented Apr 12, 2023

cmsbuild commented Apr 12, 2023

fabiocos Apr 13, 2023

civanch commented Apr 18, 2023

MC truth classes renaming #41315

MC truth classes renaming #41315

Conversation

civanch commented Apr 11, 2023

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: NO

civanch commented Apr 11, 2023

cmsbuild commented Apr 11, 2023

cmsbuild commented Apr 11, 2023

civanch commented Apr 11, 2023

cmsbuild commented Apr 11, 2023

Build

cmsbuild commented Apr 11, 2023

cmsbuild commented Apr 11, 2023

iarspider commented Apr 11, 2023

cmsbuild commented Apr 11, 2023

Build

cmsbuild commented Apr 12, 2023

cmsbuild commented Apr 12, 2023

civanch commented Apr 12, 2023

cmsbuild commented Apr 12, 2023

Comparison Summary

fabiocos Apr 13, 2023

Choose a reason for hiding this comment

civanch commented Apr 18, 2023