Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not throw exception in Trigger{Bx,Rates}Monitor if L1-uGT results are unavailable [13_1_X] #41569

Merged

Conversation

missirol
Copy link
Contributor

@missirol missirol commented May 6, 2023

backport of #41568

PR description:

From the description of #41568:

This PR updates the plugins Trigger{Bx,Rates}Monitor in order to avoid that a ProductNotFound exception is thrown if the product containing the L1-uGT results is not available.

The exception is replaced with a LogError message (this follows what is already done in another somewhat-similar HLT plugin, namely L1TriggerJSONMonitoring).

These two plugins are used online in the HLT menu to produce outputs for the online DQM.

This PR relates to #41512 (comment), and it might be relevant to current online operations. For this reason, it will be backported down to the 13_0_X release cycle.

PR validation:

None beyond the checks done for #41568.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#41568

Improvement to 2 plugins used online in the HLT menu.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2023

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_13_1_X.

It involves the following packages:

  • DQM/HLTEvF (dqm, hlt)

@Martin-Grunewald, @emanueleusai, @cmsbuild, @missirol, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@silviodonato, @mtosi this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

missirol commented May 6, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0659a5/32436/summary.html
COMMIT: cf348fe
CMSSW: CMSSW_13_1_X_2023-05-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41569/32436/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 11 lines from the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460877
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3460849
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

missirol commented May 7, 2023

+hlt

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 507fd50 into cms-sw:CMSSW_13_1_X May 11, 2023
@missirol missirol deleted the devel_triggerMonitorL1TLogError branch May 13, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants