do not allow crashes in isEmpty(int bx) method of BXVector

[missirol]

PR description:

This PR aims to make the method BXVector::isEmpty(int bx) more robust, removing the possibility of runtime crashes when this method is called.

This public method can currently crash if the value of its bx argument is outside the range of valid BXs, or if the itrs_ class member is empty (as seen in the problematic events that led to the crashes fixed by #41466).

Since this public method is used by several plugins of CMSSW, this fix will be backported down to the 13_0_X release cycle, currently used for data-taking.

PR validation:

Manual checks with some of the problematic events leading to the crashes discussed in CMSLITOPS-411.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

CMSSW_13_1_X
CMSSW_13_0_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41572/35443

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

• DataFormats/L1Trigger (l1)

@epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please review it and eventually sign? Thanks.
@dinyar, @rovere, @kreczko, @thomreis, @eyigitba this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[missirol]

please test

[cmsbuild]

-1

Failed Tests: Build HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-95dd2d/32441/summary.html
COMMIT: 50be075
CMSSW: CMSSW_13_2_X_2023-05-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41572/32441/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-06-1100/src/DataFormats/L1THGCal/src/HGCalTower.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-06-1100/src/DataFormats/L1THGCal/src/HGCalTowerMap.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-06-1100/src/DataFormats/L1THGCal/src/HGCalTriggerSums.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-06-1100/src/DataFormats/L1THGCal/src/HGCalTriggerCell.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-06-1100/src/DataFormats/L1THGCal/src/HGCalTowerMap.cc: In member function 'const l1t::HGCalTowerMap& l1t::HGCalTowerMap::operator+=(const l1t::HGCalTowerMap&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-06-1100/src/DataFormats/L1THGCal/src/HGCalTowerMap.cc:18:12: error: 'endl' was not declared in this scope; did you mean 'std::endl'?
   18 |         << endl;
      |            ^~~~
      |            std::endl
In file included from /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/include/c++/11.2.1/istream:39,
                 from /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/include/c++/11.2.1/sstream:38,


[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41572/35445

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #41572 was updated. @epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please check and sign again.

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-95dd2d/32444/summary.html
COMMIT: 9e83cfc
CMSSW: CMSSW_13_2_X_2023-05-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41572/32444/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3460836
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3460808
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1