Enable feature to recycle GEN for FastSim

[srimanob]

PR description:

As title said, this PR enables the feature to recycle GEN for FastSim workflow.

PR validation:

Try to run runTheMatrix.py --what upgrade -l 13234.0 -i all -t 4 --wm init locally.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No need of backport.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41945/35917

• This PR adds an extra 56KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): More Configurable Pixel Tracks and HIon Template #41632, Add prototype HcalNanoAOD #41607

[cmsbuild]

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

• Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[srimanob]

FYI @sunilUIET

[srimanob]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f878b/33130/summary.html
COMMIT: 16b2f5b
CMSSW: CMSSW_13_2_X_2023-06-13-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41945/33130/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

• 13240.303DAS Error

Comparison Summary

Summary:

• You potentially added 10 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 2678 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3190910
• DQMHistoTests: Total failures: 3683
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3187205
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: found differences in 1 / 46 workflows

[srimanob]

Hi @cms-sw/pdmv-l2
Could you please submit a FastSim relvals, as done in https://dmytro.web.cern.ch/dmytro/cmsprodmon/workflows.php?campaign=CMSSW_12_4_13__fastsim_noPU_2021_14TeV-1682560716
with workflow 13240.0?

This will make MinBias NoPU workflow, and GEN dataset will be generated. The above relvals has only 13240.303 which is a workflow to prepare mixing, and no GEN is stored.

Thx.

[sunilUIET]

Hi @cms-sw/pdmv-l2 Could you please submit a FastSim relvals, as done in https://dmytro.web.cern.ch/dmytro/cmsprodmon/workflows.php?campaign=CMSSW_12_4_13__fastsim_noPU_2021_14TeV-1682560716 with workflow 13240.0?

This will make MinBias NoPU workflow, and GEN dataset will be generated. The above relvals has only 13240.303 which is a workflow to prepare mixing, and no GEN is stored.

Thx.

Hi @srimanob

Sample is submitted

Sunil

[srimanob]

Thanks @sunilUIET, but the submission will not work. We need exact processing string as before, which is CMSSW_12_4_13-124X_mcRun3_2022_realistic_v12_2021_FastSim-v.

The current submission gives the processing string as CMSSW_12_4_13-124X_mcRun3_2022_realistic_v12_PR41945_FastSim-v

Technically, everything needs to be exact as this one, just to workflow 13240.0.

[sunilUIET]

Ok thanks for pointing it out

[sunilUIET]

Hi @srimanob

Sample is available

https://dmytro.web.cern.ch/dmytro/cmsprodmon/requests.php?campaign=CMSSW_12_4_13__fastsim_noPU_2021_14TeV-1686736377

Sunil

[srimanob]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f878b/33165/summary.html
COMMIT: 16b2f5b
CMSSW: CMSSW_13_2_X_2023-06-14-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41945/33165/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 11 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 2680 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3196062
• DQMHistoTests: Total failures: 3683
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3192357
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: found differences in 1 / 46 workflows

[srimanob]

+Upgrade

Changes in DQM comes from workflow 13434.0_TTbar_14TeV+2021FSPU, where the PU datasets change. This change comes from this PR where the 2021FS key is updated to last FastSim relvals in 12_4. So I would say change is expected.

After this PR, we should make a relvals with most recent release, then the key will be updated again. For now, I think it is OK as what we recycle is GEN.

[sunilUIET]

+pdmv

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1