-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous improvements to SimBeamSpotObjects
handling utilities
#41967
Conversation
… upload them to DB
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41967/35930
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@civanch, @mdhildreth, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28aaf2/33166/summary.html Comparison SummarySummary:
|
+1
|
+1 |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41967/35933
|
Pull request #41967 was updated. @civanch, @mdhildreth, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please check and sign again. |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28aaf2/33174/summary.html Comparison SummarySummary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
is there anything holding this up? |
We don't merge PRs while building a (pre) release. Now pre2 is out |
+1 |
PR description:
This is a follow-up PR to #41918.
Miscellaneous improvements to
SimBeamSpotObjects
handling utilities, including:CondCore/BeamSpotPlugins
unit tests for the exercise the plots introduced in Update utilities for SimBeamSpotObjects handling #41918SimBeamSpotObjects
payloadsfillDescriptions
whenever possibleIOMC/EventVertexGenerators/python/VtxSmearedParameters_cfi.py
PR validation:
Relies on the existing (and augmented) unit tests.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A