Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous improvements to SimBeamSpotObjects handling utilities #41967

Merged
merged 5 commits into from
Jun 16, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 14, 2023

PR description:

This is a follow-up PR to #41918.
Miscellaneous improvements to SimBeamSpotObjects handling utilities, including:

  • add expected transverse width to the payload inspector
  • add CondCore/BeamSpotPlugins unit tests for the exercise the plots introduced in Update utilities for SimBeamSpotObjects handling #41918
  • miscellaneous clean-up of the plugins to create and read SimBeamSpotObjects payloads
  • usage of auto-generated configuration fragments from fillDescriptions whenever possible
  • introduce some utilities to directly dump to sqlite and consequently upload to DB all vertex smearing PSets from IOMC/EventVertexGenerators/python/VtxSmearedParameters_cfi.py

PR validation:

Relies on the existing (and augmented) unit tests.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41967/35930

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • CondCore/BeamSpotPlugins (db)
  • CondTools/BeamSpot (db, alca)
  • IOMC/EventVertexGenerators (simulation)

@civanch, @mdhildreth, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@tocheng, @mmusich, @fabiocos, @grzanka this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Jun 14, 2023

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28aaf2/33166/summary.html
COMMIT: 04edf79
CMSSW: CMSSW_13_2_X_2023-06-14-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41967/33166/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 15 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196062
  • DQMHistoTests: Total failures: 15
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3196025
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jun 15, 2023

+1

  • dedicated unit tests pass

@civanch
Copy link
Contributor

civanch commented Jun 15, 2023

+1

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41967/35933

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

Pull request #41967 was updated. @civanch, @mdhildreth, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Jun 15, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28aaf2/33174/summary.html
COMMIT: 9877ac0
CMSSW: CMSSW_13_2_X_2023-06-15-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41967/33174/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 10 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196062
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3196040
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jun 15, 2023

+1

@civanch
Copy link
Contributor

civanch commented Jun 15, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor Author

mmusich commented Jun 16, 2023

is there anything holding this up?

@perrotta
Copy link
Contributor

is there anything holding this up?

We don't merge PRs while building a (pre) release. Now pre2 is out

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 29352bc into cms-sw:master Jun 16, 2023
@mmusich mmusich deleted the simBeamSpotImprovements branch June 16, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants