Make EDAlias_t test to compile with C++20

[makortel]

PR description:

This PR makes the EDAlias_t test to compile with C++20. Simplest change that should with both C++17 and C++20 was to change the format "literals" to constexpr string_view, and make TestProcessorConfig constructor to accept string_view argument.

PR validation:

FWCore/TestProcessor and FWCore/Integration compile in CPP20 IB.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42027/35995

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

• FWCore/Integration (core)
• FWCore/TestProcessor (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@missirol, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd4529/33276/summary.html
COMMIT: 7d032c6
CMSSW: CMSSW_13_2_X_2023-06-20-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42027/33276/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-20-1100/src/FWCore/Modules/test/test_catch2_PathStatusFilter.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-20-1100/src/FWCore/Modules/test/test_catch2_Prescaler.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-20-1100/src/FWCore/Modules/test/test_catch2_main.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-20-1100/src/FWCore/Modules/test/test_catch2_ModuloEventIDFilter.cc:4:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-20-1100/src/FWCore/Modules/test/test_catch2_ModuloEventIDFilter.cc: In function 'void ____C_A_T_C_H____T_E_S_T____4()':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-20-1100/src/FWCore/Modules/test/test_catch2_ModuloEventIDFilter.cc:65:52: error: no matching function for call to 'edm::test::TestProcessor::TestProcessor(const string&)'
   65 |   REQUIRE_THROWS_AS(edm::test::TestProcessor(config), cms::Exception);
      |                                                    ^
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-20-1100/src/FWCore/Modules/test/test_catch2_ModuloEventIDFilter.cc:1:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-20-1100/src/FWCore/TestProcessor/interface/TestProcessor.h:165:7: note: candidate: 'edm::test::TestProcessor::TestProcessor(const Config&, edm::ServiceToken)'
  165 |       TestProcessor(Config const& iConfig, ServiceToken iToken = ServiceToken());


[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42027/35996

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #42027 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please check and sign again.

[makortel]

In the end the change in TestProcessorConfig was not strictly needed. I got fooled by changing unnecessarily many string's to string_view. (maybe we want to make TestProcessorConfig to accept string_view, but that should be done in a separate PR)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42027/35998

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #42027 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please check and sign again.

[makortel]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd4529/33278/summary.html
COMMIT: 584960e
CMSSW: CMSSW_13_2_X_2023-06-20-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42027/33278/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 8 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3197958
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3197936
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[makortel]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1