Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_1_X] Protect assignments of StripDetset() in StMeasurementDetSet::getDetSet() #42041

Merged

Conversation

makortel
Copy link
Contributor

PR description:

Backport of #41936 fixing additional race condition in StMeasurementDetSet::getDetSet().

PR validation:

None beyond #41936

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #41936

makortel added 2 commits June 21, 2023 13:45
This change makes it easier to reason about thread safety elsewhere.
The assigments are a critical section and must be protected.
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 21, 2023

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_13_1_X.

It involves the following packages:

  • DataFormats/Common (core)
  • RecoLocalTracker/SiPixelClusterizer (reconstruction)
  • RecoTracker/MeasurementDet (reconstruction)

@smuzaffar, @Dr15Jones, @makortel, @clacaputo, @cmsbuild, @mandrenguyen can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @mroguljic, @missirol, @dkotlins, @ebrondol, @wddgit, @ferencek, @mtosi, @gpetruc, @mmusich, @threus, @dgulhan, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4bda37/33312/summary.html
COMMIT: ee66656
CMSSW: CMSSW_13_1_X_2023-06-21-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42041/33312/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 20 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3222811
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3222780
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

backport of #41936

@makortel
Copy link
Contributor Author

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d13b64a into cms-sw:CMSSW_13_1_X Jun 26, 2023
@makortel makortel deleted the stMeasurementDetSetAssignment_131x branch June 26, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants