-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13_1_X] Protect assignments of StripDetset() in StMeasurementDetSet::getDetSet() #42041
[13_1_X] Protect assignments of StripDetset() in StMeasurementDetSet::getDetSet() #42041
Conversation
This change makes it easier to reason about thread safety elsewhere.
The assigments are a critical section and must be protected.
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_13_1_X. It involves the following packages:
@smuzaffar, @Dr15Jones, @makortel, @clacaputo, @cmsbuild, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4bda37/33312/summary.html Comparison SummarySummary:
|
+1 |
backport of #41936 |
+core |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Backport of #41936 fixing additional race condition in
StMeasurementDetSet::getDetSet()
.PR validation:
None beyond #41936
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #41936