Top recoil hook cleaned, backport to CMSSW_13_2_X #42332

vslokenb · 2023-07-21T14:36:03Z

PR description:

Backport of recoilToTop. Pushed from 13_2_0_pre2.

PR validation:

Same as linked original PR below. Verified using scram build code-check and scram build code-format. Seem to be a couple of minor indentation changes in lines unrelated to the actual TopRecoilHook in Pythia8Hadronizer.cc as a result of the code-format tool. All differences between original PR are to account for CMSSW_13_2_X formatting needs.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Original PR found here. Backport requested by maintainers.

cmsbuild · 2023-07-21T14:36:28Z

A new Pull Request was created by @vslokenb for CMSSW_13_2_X.

It involves the following packages:

GeneratorInterface/Pythia8Interface (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

Backported from Top recoil hook cleaned #42180

Fix suggested by PR 42313. Removes useless check.

cmsbuild · 2023-07-27T13:21:58Z

Pull request #42332 was updated. @SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please check and sign again.

perrotta · 2023-07-29T15:38:07Z

backport of #42180

menglu21 · 2023-08-01T14:10:13Z

please test

cmsbuild · 2023-08-01T17:54:05Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dfc0e9/34017/summary.html
COMMIT: f4e5c6c
CMSSW: CMSSW_13_2_X_2023-08-01-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42332/34017/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 4 lines to the logs
Reco comparison results: 13 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3195634
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3195603
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

perrotta

This being based on the rather old CMSSW_3_2_0_pre2, it was a bit complicate to compare with the same PR merged in master.
At the end I managed to do it.: therefore, even if a rebase on the more recent 13_2_X IB could help, it is not mandatory, provided you apply the two small adjustments listed here needed to synchronize with the master version of the same PR.
After that (and the @cms-sw/generators-l2 signature, of course) this PR can be merged

GeneratorInterface/Pythia8Interface/plugins/TopRecoilHook.h

Co-authored-by: Andrea Perrotta <perrotta@cern.ch>

cmsbuild · 2023-08-04T11:40:34Z

Pull request #42332 was updated. @SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please check and sign again.

menglu21 · 2023-08-23T08:08:03Z

please test

GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc

perrotta · 2023-08-23T09:01:16Z

hold
(see #42332 (review))

cmsbuild · 2023-09-28T17:24:44Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dfc0e9/34956/summary.html
COMMIT: cce6879
CMSSW: CMSSW_13_2_X_2023-09-28-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42332/34956/install.sh to create a dev area with all the needed externals and cmssw changes.

Found compilation warnings

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 5 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3198243
DQMHistoTests: Total failures: 4
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3198217
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

menglu21 · 2023-10-10T12:59:18Z

@perrotta is the error related to this PR

GeneratorInterface/Pythia8Interface/plugins/TopRecoilHook.h

perrotta · 2023-10-10T13:49:01Z

@perrotta is the error related to this PR

Well, the relvals timed out is not a fault of this PR, but the compilation warnings are.
Please apply the same fix which was applied in master

menglu21 · 2023-10-10T15:08:02Z

ok, it seems I overlooked the fix, sorry for that. @vslokenb please follow @perrotta comments

Co-authored-by: Andrea Perrotta <perrotta@cern.ch>

cmsbuild · 2023-10-13T22:01:07Z

Pull request #42332 was updated. @GurpreetSinghChahal, @menglu21, @alberto-sanchez, @bbilin, @SiewYan, @cmsbuild, @mkirsano can you please check and sign again.

menglu21 · 2023-10-17T10:42:11Z

@cmsbuild please test

cmsbuild · 2023-10-17T13:49:15Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dfc0e9/35219/summary.html
COMMIT: a4bc408
CMSSW: CMSSW_13_2_X_2023-10-17-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42332/35219/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 2 lines to the logs
Reco comparison results: 12 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3198785
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3198757
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

menglu21 · 2023-10-17T15:02:49Z

+1

cmsbuild · 2023-10-17T15:03:15Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2023-10-23T14:27:58Z

@perrotta are you okay with the PR now? Have your comments been addressed?

perrotta · 2023-10-23T15:06:04Z

@perrotta are you okay with the PR now? Have your comments been addressed?

Ciao Sal. Yes, now this PR correctly implements the fix that was merged in master with #42313

antoniovilela · 2023-10-27T12:50:47Z

+1

Valdis Slokenbergs added 2 commits July 21, 2023 16:25

Backport to 13_2

8a829c8

Rest of backport to 13_2

34fa819

cmsbuild added this to the CMSSW_13_2_X milestone Jul 21, 2023

cmsbuild added generators-pending pending-signatures tests-pending orp-pending labels Jul 21, 2023

Update TopRecoilHook.h

f4e5c6c

Fix suggested by PR 42313. Removes useless check.

cmsbuild added the backport-ok label Jul 29, 2023

perrotta changed the title ~~Backport to 13_2_X~~ Top recoil hook cleaned, backport to CMSSW_13_2_X Jul 29, 2023

cmsbuild added tests-started and removed tests-pending labels Aug 1, 2023

cmsbuild added tests-approved and removed tests-started labels Aug 1, 2023

perrotta reviewed Aug 3, 2023

View reviewed changes

GeneratorInterface/Pythia8Interface/plugins/TopRecoilHook.h Outdated Show resolved Hide resolved

GeneratorInterface/Pythia8Interface/plugins/TopRecoilHook.h Outdated Show resolved Hide resolved

vslokenb and others added 2 commits August 4, 2023 13:40

Update GeneratorInterface/Pythia8Interface/plugins/TopRecoilHook.h

d1c3b31

Co-authored-by: Andrea Perrotta <perrotta@cern.ch>

Update GeneratorInterface/Pythia8Interface/plugins/TopRecoilHook.h

81dde92

Co-authored-by: Andrea Perrotta <perrotta@cern.ch>

cmsbuild added tests-pending and removed tests-approved labels Aug 4, 2023

cmsbuild added tests-started and removed tests-pending labels Aug 23, 2023

perrotta reviewed Aug 23, 2023

View reviewed changes

GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc Outdated Show resolved Hide resolved

cmsbuild added the tests-started label Sep 28, 2023

cmsbuild added tests-rejected and removed tests-started labels Sep 28, 2023

perrotta reviewed Oct 10, 2023

View reviewed changes

GeneratorInterface/Pythia8Interface/plugins/TopRecoilHook.h Outdated Show resolved Hide resolved

Update GeneratorInterface/Pythia8Interface/plugins/TopRecoilHook.h

a4bc408

Co-authored-by: Andrea Perrotta <perrotta@cern.ch>

cmsbuild added tests-pending and removed tests-rejected labels Oct 13, 2023

cmsbuild added tests-started and removed tests-pending labels Oct 17, 2023

cmsbuild added tests-approved and removed tests-started labels Oct 17, 2023

cmsbuild added generators-approved fully-signed and removed generators-pending pending-signatures labels Oct 17, 2023

cmsbuild added orp-approved and removed orp-pending labels Oct 27, 2023

cmsbuild merged commit b81e432 into cms-sw:CMSSW_13_2_X Oct 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Top recoil hook cleaned, backport to CMSSW_13_2_X #42332

Top recoil hook cleaned, backport to CMSSW_13_2_X #42332

vslokenb commented Jul 21, 2023 •

edited

Loading

cmsbuild commented Jul 21, 2023 •

edited

Loading

cmsbuild commented Jul 27, 2023

perrotta commented Jul 29, 2023

menglu21 commented Aug 1, 2023

cmsbuild commented Aug 1, 2023

perrotta left a comment

cmsbuild commented Aug 4, 2023

menglu21 commented Aug 23, 2023

perrotta commented Aug 23, 2023

cmsbuild commented Sep 28, 2023

menglu21 commented Oct 10, 2023

perrotta commented Oct 10, 2023 •

edited

Loading

menglu21 commented Oct 10, 2023

cmsbuild commented Oct 13, 2023

menglu21 commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

menglu21 commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

rappoccio commented Oct 23, 2023

perrotta commented Oct 23, 2023

antoniovilela commented Oct 27, 2023

Top recoil hook cleaned, backport to CMSSW_13_2_X #42332

Top recoil hook cleaned, backport to CMSSW_13_2_X #42332

Conversation

vslokenb commented Jul 21, 2023 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Jul 21, 2023 • edited Loading

cmsbuild commented Jul 27, 2023

perrotta commented Jul 29, 2023

menglu21 commented Aug 1, 2023

cmsbuild commented Aug 1, 2023

Comparison Summary

perrotta left a comment

Choose a reason for hiding this comment

cmsbuild commented Aug 4, 2023

menglu21 commented Aug 23, 2023

perrotta commented Aug 23, 2023

cmsbuild commented Sep 28, 2023

RelVals-INPUT

Comparison Summary

menglu21 commented Oct 10, 2023

perrotta commented Oct 10, 2023 • edited Loading

menglu21 commented Oct 10, 2023

cmsbuild commented Oct 13, 2023

menglu21 commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

Comparison Summary

menglu21 commented Oct 17, 2023

cmsbuild commented Oct 17, 2023

rappoccio commented Oct 23, 2023

perrotta commented Oct 23, 2023

antoniovilela commented Oct 27, 2023

vslokenb commented Jul 21, 2023 •

edited

Loading

cmsbuild commented Jul 21, 2023 •

edited

Loading

perrotta commented Oct 10, 2023 •

edited

Loading