-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hgc geometry v5 1 #4241
Hgc geometry v5 1 #4241
Conversation
A new Pull Request was created by @vandreev11 for CMSSW_6_2_X_SLHC. Hgc geometry v5 1 It involves the following packages: Geometry/HGCalCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks. |
@vandreev11 @pfs Was this presented in a software or general meeting? Just curious to go read about it. |
@lgray It was referred in the last software meeting and it was discussed in the general meeting. v5 is however not meant for production, it's part of the developments on-going. |
@pfs Ah, ok. Missed the last software meeting, I'll go check it out. Thanks! |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @fratnikov, @mark-grimes can you please take care of it? |
merge Tested with 4 muons (xxx00) and single pions (xxx61). Only the expected failures, namely: 12600 crashes in step 2:
12661 crashes in step 2:
122xx, 142xx and 144xx fail in step 4:
|
Pull request #4241 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please check and sign again. |
Hi Mark, asking you just to be sure, I committed it almost at the same moment I got your message. Thanks, cheers, On Jun 16, 2014, at 6:05 PM, Mark Grimes wrote:
|
Yes, I've checked the logs and it was merged. It wasn't part of my test though. |
@bsunanda, @pfs
new HGCAL concept geometry xml files, version 5