-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of DeepTau SONIC producers #43158
Implementation of DeepTau SONIC producers #43158
Conversation
FYI, @yongbinfeng |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43158/37460
|
A new Pull Request was created by @mbluj for master. It involves the following packages:
@fabiocos, @davidlange6, @jfernan2, @rappoccio, @mandrenguyen, @antoniovilela, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
can you add the new |
test parameters: |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43158/37463
|
Pull request #43158 was updated. @davidlange6, @mandrenguyen, @antoniovilela, @fabiocos, @jfernan2, @cmsbuild, @rappoccio can you please check and sign again. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43158/37465
|
Pull request #43158 was updated. @davidlange6, @cmsbuild, @rappoccio, @antoniovilela, @fabiocos, @jfernan2, @mandrenguyen can you please check and sign again. |
please test |
@antoniovilela 11 original commits were squashed to 3, I hope it is fine. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43158/37609
|
Pull request #43158 was updated. @antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @rappoccio, @jfernan2, @mandrenguyen can you please check and sign again. |
please test |
Many thanks. |
+1 |
merge
|
+reconstruction |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
This PR introduces the DeepTauId SONIC producer to CMSSW.
To implement the SONIC version of DeepTauId producer a new base class
DeepTauIdBase
was added. The base class contains common part of DeepTauId code while (existing)DeepTauId
and (newly added)DeepTauIdSONIC
derived classes provide, respectively, direct interface and interface via TritonService to a TF DeepTau model. The common code was moved from theDeepTauId
class.This PR requires SONIC model and configuration files to be added with cms-data/RecoTauTag-TrainingFiles#12.
PR validation:
PR validated using the test script runDeepTauIDsOnMiniAOD.py. To enable/disable SONIC one should set the useSONIC flag appropriately. Tested with and without SONIC and confirmed the outputs are in both cases the same as with the unmodified code.
Tested also wf. 12434.0 (ttbar 2023 MC) which is a kind of "typical" full Run3 workflow (GEN->NanoAOD).