Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of DeepTau SONIC producers #43158

Merged

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Oct 31, 2023

PR description:

This PR introduces the DeepTauId SONIC producer to CMSSW.
To implement the SONIC version of DeepTauId producer a new base class DeepTauIdBase was added. The base class contains common part of DeepTauId code while (existing) DeepTauId and (newly added) DeepTauIdSONIC derived classes provide, respectively, direct interface and interface via TritonService to a TF DeepTau model. The common code was moved from the DeepTauId class.

This PR requires SONIC model and configuration files to be added with cms-data/RecoTauTag-TrainingFiles#12.

PR validation:

PR validated using the test script runDeepTauIDsOnMiniAOD.py. To enable/disable SONIC one should set the useSONIC flag appropriately. Tested with and without SONIC and confirmed the outputs are in both cases the same as with the unmodified code.

Tested also wf. 12434.0 (ttbar 2023 MC) which is a kind of "typical" full Run3 workflow (GEN->NanoAOD).

@mbluj
Copy link
Contributor Author

mbluj commented Oct 31, 2023

FYI, @yongbinfeng

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43158/37460

  • This PR adds an extra 60KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbluj for master.

It involves the following packages:

  • Configuration/ProcessModifiers (operations)
  • RecoTauTag/RecoTau (reconstruction)

@fabiocos, @davidlange6, @jfernan2, @rappoccio, @mandrenguyen, @antoniovilela, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos, @azotz, @Martin-Grunewald, @makortel, @missirol, @mbluj this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

can you add the new deepTauSonicTriton modifier to allSonicTriton? (apologies, didn't notice this earlier)

@kpedro88
Copy link
Contributor

kpedro88 commented Oct 31, 2023

test parameters:
pull_requests = cms-sw/cmsdist#8815
workflows = 11824.9001,24834.9001
relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,identity,ged,machine,premix,nano,gpu,2017,2026

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43158/37463

  • This PR adds an extra 64KB to repository

@cmsbuild
Copy link
Contributor

Pull request #43158 was updated. @davidlange6, @mandrenguyen, @antoniovilela, @fabiocos, @jfernan2, @cmsbuild, @rappoccio can you please check and sign again.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43158/37465

  • This PR adds an extra 60KB to repository

@cmsbuild
Copy link
Contributor

Pull request #43158 was updated. @davidlange6, @cmsbuild, @rappoccio, @antoniovilela, @fabiocos, @jfernan2, @mandrenguyen can you please check and sign again.

@jfernan2
Copy link
Contributor

please test

@mbluj
Copy link
Contributor Author

mbluj commented Nov 10, 2023

@antoniovilela 11 original commits were squashed to 3, I hope it is fine.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43158/37609

  • This PR adds an extra 56KB to repository

@cmsbuild
Copy link
Contributor

Pull request #43158 was updated. @antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @rappoccio, @jfernan2, @mandrenguyen can you please check and sign again.

@kpedro88
Copy link
Contributor

please test

@antoniovilela
Copy link
Contributor

@antoniovilela 11 original commits were squashed to 3, I hope it is fine.

Many thanks.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a8546/35744/summary.html
COMMIT: e691f92
CMSSW: CMSSW_14_0_X_2023-11-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43158/35744/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a8546/35744/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a8546/35744/git-merge-result

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially added 272 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 31725 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 3560789
  • DQMHistoTests: Total failures: 98616
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3462151
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3.286999999999999 KiB( 51 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.244 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11634.0,... ): 0.259 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13234.0,... ): 0.126 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 250202.181 ): 0.288 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.373 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11824.9001 ): 0.294 KiB SiStrip/MechanicalView
  • Checked 223 log files, 176 edm output root files, 52 DQM output files
  • TriggerResults: found differences in 8 / 50 workflows

@antoniovilela
Copy link
Contributor

+1

@antoniovilela
Copy link
Contributor

merge

  • Merging after squash.

@cmsbuild cmsbuild merged commit b179031 into cms-sw:master Nov 13, 2023
@jfernan2
Copy link
Contributor

+reconstruction

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants