-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Change Sonic to use ExternalFailure exception #43274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Sonic to use ExternalFailure exception #43274
Conversation
Using the new exception type will make cmsRun return a more meaningful return value (which is what most code which launch cmsRun use to classify failures).
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43274/37681
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages:
@fwyzard, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0aca83/35813/summary.html Comparison SummarySummary:
|
Comparison differences are related to #39803 |
+heterogeneous |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
@cms-sw/orp-l2 Could this PR be merged? Thanks! |
+1 |
PR description:
Using the new exception type will make cmsRun return a more meaningful return value (which is what most code which launch cmsRun use to classify failures).
PR validation:
Code compiles.