HLT menu development for 13_2_X (5/N) [14_0_X]

[mmusich]

PR description:

Development of HLT menus for CMSSW_13_2_X.

• This is the final integration of the development in 13_2_X before moving to the new production cycle

This is the PR for the master branch, which will then be backported down to 13_2_X (the latter is the release cycle currently used for Run-3 HLT-menu development).

This version of the HIon HLT menu corresponds to the latest online updates performed by TSG/FOG to the "V1.1" menu for the 2023 heavy-ion data-taking period (the corresponding frozen menu is not added to the release, as not included in any central releae validation workflow).

In addition, the following changes are included:

• 86106cf: Update of L1T HIon menu to v1_1_5 in autoCondHLT.py
• 4d81e1e: revert customization of FEVTDEBUGHLTEventContent introduced in PR customize HLT offline DQM for Run3 PbPb and introduce HI 2023A relval workflow (with reHLT) #43141

This update includes the integration of the following JIRA tickets:

• CMSHLT-2970 [TSG]: Online changes on 2023 HION menu v1.1
• CMSHLT-2790 [TSG]: Remove prescalers from RatesMonitoring and HLTAnalyzerEndpath
• CMSHLT-2964 [TSG]: Update of ReleaseValidation EventContent for HIon DQM
• CMSHLT-2963 [HIN]: Add HIZeroBias PDs and pass-throughs for randoms and new L1T-Jet(UPC) seeds to "V1.1" HIon menu
• CMSHLT-2898 [HIN]: Compression settings of HLT OutputModules in 2023 HIon menu
• CMSHLT-2958 [HIN]: Increase prescale by factor of 5 for Dataset_HIOnlineMonitor
• CMSHLT-2947 [HIN]: Add (12) UPC HLT paths with corresponding L1 seeds for ZDC asymmetry
• CMSHLT-2887 [HIG]: Technical: rationalise VBF-parking triggers
• CMSHLT-2956 [HIN]: Add ZDC1n seeded trigger paths on top of V1.1
• CMSHLT-2955 [HIN]: Change version number of HLT_HI*_HighRate_v to "3"

PR validation:

TSG integration tests.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but it will be backported to CMSSW_13_2_X.

[mmusich]

enable gpu

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43300/37738

• This PR adds an extra 904KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• Configuration/EventContent (operations)
• Configuration/HLT (hlt)
• HLTrigger/Configuration (hlt)

@Martin-Grunewald, @rappoccio, @davidlange6, @fabiocos, @antoniovilela, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@silviodonato, @fabiocos, @missirol, @Martin-Grunewald this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f5df3/35881/summary.html
COMMIT: 4d81e1e
CMSSW: CMSSW_14_0_X_2023-11-16-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43300/35881/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 391 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3362842
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 32
• DQMHistoTests: Total successes: 3362784
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -37.752 KiB( 49 files compared)
• DQMHistoSizes: changed ( 12434.0,... ): -9.438 KiB HLT/Filters
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: found differences in 4 / 48 workflows

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 37 differences found in the comparisons
• DQMHistoTests: Total files compared: 3
• DQMHistoTests: Total histograms compared: 39740
• DQMHistoTests: Total failures: 1152
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 38588
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
• Checked 8 log files, 10 edm output root files, 3 DQM output files
• TriggerResults: found differences in 2 / 2 workflows

[mmusich]

DQMHistoSizes: Histogram memory added: -37.752 KiB( 49 files compared)
DQMHistoSizes: changed ( 12434.0,... ): -9.438 KiB HLT/Filters
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: found differences in 4 / 48 workflows

changes look compatible with the removal of certain VBF paths (implemented in CMSHLT-2887 [HIG]: Technical: rationalise VBF-parking triggers )

[mmusich]

+hlt

• see HLT menu development for 13_2_X (5/N) [14_0_X] #43300 (comment)

[antoniovilela]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

[mmusich]

it looks like this update is causing now crashes in several Run2023 relval workflows (see relval log). I am having a look. Pity that we don't have enough 2023 real data workflows running in the short matrix.

[mmusich]

so also thanks to @missirol we diagnosed the problem here:

cmssw/HLTrigger/JetMET/plugins/HLTL1TMatchedJetsVBFFilter.h

Line 174 in 9e9d289

for (unsigned int i = 0; i < jetIndices.size() - 1; i++) {

that was introduced back in PR #42543.
When jetIndices is equal to 0 , jetIndices.size() - 1 is not -1 as the latter is always converted to unsigned int and hence the loop never ends.

[missirol]

Thanks @mmusich , the bugfix is in #43324 (14_0_X), #43325 (13_3_X) and #43326 (13_2_X).

[cmsbuild]

cms-bot internal usage