SimTauCPLink - Adding a link between GenTaus and CaloParticles

[agrubercms]

This PR introduces a new object called SimTauCPLink, which creates a link between a tau GenParticle and CaloParticles in HGCal (if any are found).
This should be useful for validation purposes, to have truth information available for whether a CaloParticle is coming from a tau or not.
This PR contains the new SimTauCPLink object, its corresponding EDProducer and an EDAnalyzer for testing purposes.

Validation

runTheMatrix.py -l limited -i all --ibeos

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43468/38021

• This PR adds an extra 104KB to repository

• Found files with invalid states:

  • SimGeneral/Debugging/plugins/patatrackAnalyzer.cc:
    • Added: 16c1765
    • Deleted: 47bdda7
  • SimGeneral/Debugging/test/simTauDecayDump_cfg.py:
    • Added: 47bdda7
    • Modified: 4f75eea, 963f83e, ddccab9, 7e0d214, 80a542c, 9c87ca8
    • Deleted: aaeffa0
  • SimGeneral/Debugging/plugins/SimTauProducer.cc:
    • Added: 4f75eea
    • Modified: 963f83e, ddccab9, bcc7fde, 7e0d214, 6c415f6, 9c87ca8
    • Deleted: aaeffa0
  • RecoLocalCalo/HGCalRecProducers/python/SimTauDecayCaloParticle_cfi.py:
    • Added: 5ea668c
    • Deleted: 9c87ca8
  • SimDataFormats/CaloAnalysis/interface/SimTauDecayCaloParticle.h:
    • Added: 963f83e
    • Modified: ddccab9, 7e0d214
    • Deleted: 6c415f6
  • SimGeneral/Debugging/test/ConfFile_cfg.py:
    • Added: 16c1765
    • Deleted: 47bdda7

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43468/38021/code-checks.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43468/38021/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43468/38021/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43468/38021/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43468/38022

• This PR adds an extra 108KB to repository

• Found files with invalid states:

  • SimGeneral/Debugging/plugins/patatrackAnalyzer.cc:
    • Added: 16c1765
    • Deleted: 47bdda7
  • SimGeneral/Debugging/test/simTauDecayDump_cfg.py:
    • Added: 47bdda7
    • Modified: 4f75eea, 963f83e, ddccab9, 7e0d214, 80a542c, 9c87ca8
    • Deleted: aaeffa0
  • SimGeneral/Debugging/plugins/SimTauProducer.cc:
    • Added: 4f75eea
    • Modified: 963f83e, ddccab9, bcc7fde, 7e0d214, 6c415f6, 9c87ca8
    • Deleted: aaeffa0
  • RecoLocalCalo/HGCalRecProducers/python/SimTauDecayCaloParticle_cfi.py:
    • Added: 5ea668c
    • Deleted: 9c87ca8
  • SimDataFormats/CaloAnalysis/interface/SimTauDecayCaloParticle.h:
    • Added: 963f83e
    • Modified: ddccab9, 7e0d214
    • Deleted: 6c415f6
  • SimGeneral/Debugging/test/ConfFile_cfg.py:
    • Added: 16c1765
    • Deleted: 47bdda7

[cmsbuild]

A new Pull Request was created by @agrubercms for master.

It involves the following packages:

• RecoHGCal/Configuration (upgrade, reconstruction)
• SimCalorimetry/HGCalAssociatorProducers (simulation, upgrade)
• SimDataFormats/CaloAnalysis (simulation)
• SimGeneral/Debugging (simulation)
• Validation/Configuration (dqm, simulation)

@tjavaid, @mdhildreth, @cmsbuild, @jfernan2, @antoniovagnerini, @mandrenguyen, @rvenditti, @nothingface0, @civanch, @syuvivida, @srimanob can you please review it and eventually sign? Thanks.
@ReyerBand, @bsunanda, @sobhatta, @sameasy, @thomreis, @apsallid, @slomeo, @missirol, @ebrondol, @hatakeyamak, @wang0jin, @rovere, @fabiocos, @youyingli, @forthommel, @lecriste, @felicepantaleo this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[felicepantaleo]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-883989/36243/summary.html
COMMIT: 3760111
CMSSW: CMSSW_14_0_X_2023-11-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43468/36243/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 363 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3370032
• DQMHistoTests: Total failures: 76
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3369934
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[jfernan2]

+reconstruction

[danielwinterbottom]

+1

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_14_1_X. Please open a backport if it should also go in to CMSSW_14_0_X.

[tjavaid]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-883989/37288/summary.html
COMMIT: d9eb42d
CMSSW: CMSSW_14_1_X_2024-02-07-1100/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43468/37288/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 88 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 68 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3248626
• DQMHistoTests: Total failures: 1192
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3247412
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[tjavaid]

+1

• spurious differences observed from unstable WF 12434.7 (open issue spurious differences in outputs of Run-3 wfs *.7 #39803 )

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1