-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DQM DT] Changes to put back DT Noise plot in Online DQM #43569
Conversation
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43569/38195
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43569/38197
|
A new Pull Request was created by @jfernan2 for master. It involves the following packages:
@tjavaid, @nothingface0, @antoniovagnerini, @syuvivida, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
thanks @jfernan2 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9224b3/36498/summary.html Comparison SummarySummary:
|
This PR has been tested successfully by applying the PR on top of CMSSW_13_0_10 at online DQM machines at p5, using the DQM streamers of 370580. Additionally, dmwm/deployment#1296 for DQMGUI layout was also tested. We had to test in CMSSW_13_0_10 as CMSSW_14_0_X cannot read the streamers of 13_0_10. |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9224b3/37272/summary.html Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR brings back a DT Noise plot in Online DQM. It sets a contant threshold of 500Hz for noise per single wire in Cosmics level, while it sets a variable threshold per chamber in Collisions taking into account known expected background rates at DT subdetector from previous studies. A Inst. Lumi of 2E34 is assumed
These changes affect ONLY Online DQM GUI
Presented and approved on DT DPG meeting:
https://indico.cern.ch/event/1357468/contributions/5715460/attachments/2771641/4830403/DTnoiseMeeting.pdf
PR validation:
Tested privately in development DQM GUI with collision and cosmic runs
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
No backport needed