Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DQM DT] Changes to put back DT Noise plot in Online DQM #43569

Merged
merged 7 commits into from
Feb 9, 2024

Conversation

jfernan2
Copy link
Contributor

PR description:

This PR brings back a DT Noise plot in Online DQM. It sets a contant threshold of 500Hz for noise per single wire in Cosmics level, while it sets a variable threshold per chamber in Collisions taking into account known expected background rates at DT subdetector from previous studies. A Inst. Lumi of 2E34 is assumed

These changes affect ONLY Online DQM GUI

Presented and approved on DT DPG meeting:

https://indico.cern.ch/event/1357468/contributions/5715460/attachments/2771641/4830403/DTnoiseMeeting.pdf

PR validation:

Tested privately in development DQM GUI with collision and cosmic runs

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No backport needed

@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Dec 14, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 14, 2023

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43569/38195

  • This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@jfernan2
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43569/38197

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

  • DQM/DTMonitorClient (dqm)
  • DQM/Integration (dqm)

@tjavaid, @nothingface0, @antoniovagnerini, @syuvivida, @rvenditti can you please review it and eventually sign? Thanks.
@battibass, @batinkov, @francescobrivio, @threus this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@battibass
Copy link

thanks @jfernan2

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9224b3/36498/summary.html
COMMIT: bac70c5
CMSSW: CMSSW_14_0_X_2023-12-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43569/36498/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@syuvivida
Copy link
Contributor

This PR has been tested successfully by applying the PR on top of CMSSW_13_0_10 at online DQM machines at p5, using the DQM streamers of 370580. Additionally, dmwm/deployment#1296 for DQMGUI layout was also tested. We had to test in CMSSW_13_0_10 as CMSSW_14_0_X cannot read the streamers of 13_0_10.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@tjavaid
Copy link

tjavaid commented Feb 7, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9224b3/37272/summary.html
COMMIT: 7d42231
CMSSW: CMSSW_14_1_X_2024-02-07-1100/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43569/37272/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 85 lines to the logs
  • Reco comparison results: 42 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3248626
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248604
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Feb 8, 2024

+1

  • Tests on the online DQM machines at P5 OK with Run 370580 using CMSSW_13_0_14 (thanks @syuvivida and @nothingface0 )

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 324a5aa into cms-sw:master Feb 9, 2024
17 checks passed
@jfernan2 jfernan2 deleted the fixDtDQMNoisePlot branch February 22, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants