-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding decay files for UpsilonXS [10_6_X] #43812
Conversation
A new Pull Request was created by @michael-pitt (Michael Pitt) for CMSSW_10_6_X. It involves the following packages:
@mkirsano, @SiewYan, @bbilin, @menglu21, @GurpreetSinghChahal, @cmsbuild, @alberto-sanchez can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-39334c/37130/summary.html Comparison SummaryThe workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Summary:
|
+1. the changes are tested locally and the files are needed for the ul branch. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
Dear release team (@sextonkennedy, @antoniovilela, @rappoccio), can you check this PR? it is a bit urgent. The PR is an addition of a few files to the data folder, required by new simulations. |
+1 |
@michael-pitt @cms-sw/generators-l2 Michael, Meng, Going back to this, don't you need to backport cms-sw/cmsdist#8946, that is changing the tag that will be fetched from the GeneratorInterface/EvtGenInterface data repository corresponding to cms-data/GeneratorInterface-EvtGenInterface#24 ? I am not sure if this PR (#43812) does the job. I ask @iarspider @aandvalenzuela In any case backporting the tag in cmsdist is the usual way of achieving this. |
Hello @antoniovilela, In any case, I was about to open the backport manually but I realized the tag is already different in cmsdist 10_6_X branch. For example, branch Thanks! |
@iarspider, feel free to correct me if I am wrong |
Hi Andrea, Many thanks for checking and sorry for the noise. It was backported and I had forgotten: cms-sw/cmsdist#9012 I got confused looking at this PR. Thanks again. |
This is a backport from cms-data/GeneratorInterface-EvtGenInterface#24