Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding decay files for UpsilonXS [10_6_X] #43812

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

michael-pitt
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @michael-pitt (Michael Pitt) for CMSSW_10_6_X.

It involves the following packages:

  • GeneratorInterface/EvtGenInterface (generators)

@mkirsano, @SiewYan, @bbilin, @menglu21, @GurpreetSinghChahal, @cmsbuild, @alberto-sanchez can you please review it and eventually sign? Thanks.
@mkirsano, @alberto-sanchez this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 30, 2024

cms-bot internal usage

@bbilin
Copy link
Contributor

bbilin commented Jan 31, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-39334c/37130/summary.html
COMMIT: 3b4d781
CMSSW: CMSSW_10_6_X_2024-01-28-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43812/37130/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215351
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 144 log files, 103 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@bbilin
Copy link
Contributor

bbilin commented Feb 1, 2024

+1. the changes are tested locally and the files are needed for the ul branch.

@bbilin
Copy link
Contributor

bbilin commented Feb 1, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@michael-pitt
Copy link
Contributor Author

Dear release team (@sextonkennedy, @antoniovilela, @rappoccio), can you check this PR? it is a bit urgent. The PR is an addition of a few files to the data folder, required by new simulations.
NOTE: There is no validation for master, as these files are available in cms-data

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3bcbd77 into cms-sw:CMSSW_10_6_X Feb 2, 2024
10 checks passed
@antoniovilela
Copy link
Contributor

@michael-pitt @cms-sw/generators-l2

Michael, Meng,

Going back to this, don't you need to backport cms-sw/cmsdist#8946, that is changing the tag that will be fetched from the GeneratorInterface/EvtGenInterface data repository corresponding to cms-data/GeneratorInterface-EvtGenInterface#24 ?

I am not sure if this PR (#43812) does the job. I ask @iarspider @aandvalenzuela

In any case backporting the tag in cmsdist is the usual way of achieving this.

@aandvalenzuela
Copy link
Contributor

Hello @antoniovilela,
I think bot only updates the tag automatically for the base branch, so we would need to backport it.

In any case, I was about to open the backport manually but I realized the tag is already different in cmsdist 10_6_X branch. For example, branch IB/CMSSW_10_6_X/gcc700 has GeneratorInterface-EvtGenInterface=V02-09-00 (See https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_10_6_X/gcc700/data/cmsswdata.txt#L8). Should I go ahead and backport it anyways?

Thanks!
Andrea

@aandvalenzuela
Copy link
Contributor

@iarspider, feel free to correct me if I am wrong

@antoniovilela
Copy link
Contributor

Hello @antoniovilela,
I think bot only updates the tag automatically for the base branch, so we would need to backport it.

In any case, I was about to open the backport manually but I realized the tag is already different in cmsdist 10_6_X branch. For example, branch IB/CMSSW_10_6_X/gcc700 has GeneratorInterface-EvtGenInterface=V02-09-00 (See https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_10_6_X/gcc700/data/cmsswdata.txt#L8). Should I go ahead and backport it anyways?

Thanks!
Andrea

Hi Andrea,

Many thanks for checking and sorry for the noise. It was backported and I had forgotten: cms-sw/cmsdist#9012

I got confused looking at this PR.

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants