-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue exception for ROOT file forward incompatiblity problem [13_0] #43898
Conversation
This assert was happening when an old release tried to read a file written by a newer release.
please test |
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_13_0_X. It involves the following packages:
@makortel, @Dr15Jones, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01a38b/37283/summary.html Comparison SummarySummary:
|
+core |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Caused by backporting cms-sw#42742 on top of cms-sw#43898
Caused by backporting cms-sw#42742 on top of cms-sw#43898
PR description:
Throw an exception if the ParameterSet parsing finds an unknown entry type. This problem is occurring presently in older releases if they try to read files which contain the new string encoding for ParameterSets.
PR validation:
This same code was tested in CMSSW_13_0_17 and properly throws the proper exception type containing the proper information when reading a file generated in CMSSW_13_3.
If this PR is a backport please specify the original PR and why you need to backport that PR.
Part of large scale backport of #43894
fixes cms-sw/framework-team#804