Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to ConfDb 14_0_0_pre3 template and addOnTests bug fix [14_1_X] #43906

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

Martin-Grunewald
Copy link
Contributor

PR description:

Migration to ConfDb 14_0_0_pre3 template and addOnTests bug fix [14_1_X]

PR validation:

TSG tests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 14_0 (data taking release)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2024

cms-bot internal usage

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43906/38758

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2024

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for master.

It involves the following packages:

  • Configuration/HLT (hlt)
  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks.
@fabiocos, @silviodonato, @missirol this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43906/38762

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2024

Pull request #43906 was updated. @mmusich, @Martin-Grunewald can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-361041/37304/summary.html
COMMIT: 57ec150
CMSSW: CMSSW_14_1_X_2024-02-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43906/37304/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 87 lines to the logs
  • Reco comparison results: 58 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3248616
  • DQMHistoTests: Total failures: 1327
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3247267
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.003 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 141.042,... ): -0.001 KiB HLT/Filters
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 2 / 46 workflows

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2024

Pull request #43906 was updated. @mmusich, @Martin-Grunewald can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Feb 8, 2024

unhold

@cmsbuild cmsbuild removed the hold label Feb 8, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-361041/37312/summary.html
COMMIT: bc2e869
CMSSW: CMSSW_14_1_X_2024-02-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43906/37312/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 64 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3248616
  • DQMHistoTests: Total failures: 1195
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3247399
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.003 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 141.042,... ): -0.001 KiB HLT/Filters
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0ca09b5 into cms-sw:master Feb 9, 2024
11 checks passed
@mmusich mmusich deleted the HLTdevelopment140X_for141X branch February 11, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants