Correction of MTD ETL Validation: hits accumulation on a pixel-basis

[ctarricone]

PR description:

The proposed correction of the validation involves adjusting the accumulation process to be pixel-level during SimHits processing, aligning it with the digitization.

As it stands, LGAD pixels collect signals and it is imperative that SimHits be accumulated on a per-pixel basis. This pixel-level accumulation is consistent with the digitization [1].

Contrary to this, in the validation, the accumulation is currently performed solely based on modules (DetId), as in the BTL.
While this may not significantly impact processes without pile-up due to the relatively low occupancy, it becomes a critical concern under high pile-up conditions.

In order to consistently test changes in the ETL digitization [2] it is crucial to rectify this discrepancy.

[1] https://github.com/cms-sw/cmssw/blob/master/SimFastTiming/FastTimingCommon/src/ETLDeviceSim.cc#L78
[2] #43762

[cmsbuild]

cms-bot internal usage

[ctarricone]

@fabiocos @martinamalberti FYI

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43928/38782

• This PR adds an extra 44KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Validation/MtdValidation/plugins/EtlLocalRecoValidation.cc modified in PR(s): [MTD simulation, validation]: implementation of MTD clusters association maps #43913
  • File Validation/MtdValidation/plugins/MtdTracksValidation.cc modified in PR(s): [MTD simulation, validation]: implementation of MTD clusters association maps #43913, MTD reconstruction: introduction of mass-dependent uncertainty on track time of flight #43918

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43928/38782/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43928/38782/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[fabiocos]

@ctarricone probably this PR will have to take into account #43913 as far as MtdTracksValidation is concerned

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43928/38784

• This PR adds an extra 44KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Validation/MtdValidation/plugins/EtlLocalRecoValidation.cc modified in PR(s): [MTD simulation, validation]: implementation of MTD clusters association maps #43913
  • File Validation/MtdValidation/plugins/MtdTracksValidation.cc modified in PR(s): [MTD simulation, validation]: implementation of MTD clusters association maps #43913, MTD reconstruction: introduction of mass-dependent uncertainty on track time of flight #43918

[cmsbuild]

A new Pull Request was created by @ctarricone (Cristiano Tarricone) for master.

It involves the following packages:

• Validation/MtdValidation (dqm)

@cmsbuild, @nothingface0, @syuvivida, @tjavaid, @rvenditti, @antoniovagnerini can you please review it and eventually sign? Thanks.
@missirol, @fabiocos this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1def66/37329/summary.html
COMMIT: 2c671c5
CMSSW: CMSSW_14_1_X_2024-02-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43928/37329/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 24896.0A fatal system signal has occurred: segmentation violation
• 24834.0A fatal system signal has occurred: segmentation violation
• 23234.0A fatal system signal has occurred: segmentation violation

Expand to see more relval errors ...

• 25034.999
• 24834.911

[fabiocos]

@ctarricone at this point we may close this PR, as a replacement for it was merged already

[fabiocos]

@ctarricone this PR is reported as possible source of conflict in any PR on MTD validation. As it is superseded, could you please just close it? Thanks

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

[antoniovilela]

ping (to make bot change milestone)

[fabiocos]

-mtd

[fabiocos]

this PR is definitely obsolete and superseded but other developments. I would be better to simply close it.

[antoniovagnerini]

-1

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_15_0_X. Please open a backport if it should also go in to CMSSW_14_2_X.