-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ESProducerExternalWork::setWhatAcquiredProducedWithLambda() #43988
Conversation
cms-bot internal usage |
@wddgit Could you review? |
@cmsbuild, please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43988/38909
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages:
@smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
I will take a look at it. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd7f87/37509/summary.html Comparison SummarySummary:
|
+1 |
Thanks. In the mean time I found one deficiency that I'm working on to improve right now (if the second argument of the produce-lambda has |
811dafb
to
d292cfb
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43988/38925
|
d292cfb
to
bbf6db2
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43988/38942
|
@cmsbuild, please test |
Pull request #43988 was updated. @Dr15Jones, @smuzaffar, @makortel can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd7f87/37558/summary.html Comparison SummarySummary:
|
+core |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
While trying to make Alpaka ESProducers asynchronous, I encountered the type-deducing overload of
ESProducerExternalWork::setWhatAcquiredProducedWithLambda()
didn't compile, and we didn't have tests for it. This PR fixes the problem by adding necessary partial specializations ofedm::eventsetup::impl::ReturnArgumentTypesImpl
to account for the second argument toacquire()
/produce()
(edm::WaitingTaskWithArenaHolder
/ return type of theacquire()
), and extends the tests.PR validation:
Unit tests run.