Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESProducerExternalWork::setWhatAcquiredProducedWithLambda() #43988

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

makortel
Copy link
Contributor

PR description:

While trying to make Alpaka ESProducers asynchronous, I encountered the type-deducing overload of ESProducerExternalWork::setWhatAcquiredProducedWithLambda() didn't compile, and we didn't have tests for it. This PR fixes the problem by adding necessary partial specializations of edm::eventsetup::impl::ReturnArgumentTypesImpl to account for the second argument to acquire()/produce() (edm::WaitingTaskWithArenaHolder / return type of the acquire()), and extends the tests.

PR validation:

Unit tests run.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 15, 2024

cms-bot internal usage

@makortel
Copy link
Contributor Author

@wddgit Could you review?

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43988/38909

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

  • FWCore/Framework (core)
  • FWCore/Integration (core)

@smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@wddgit, @missirol this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@wddgit
Copy link
Contributor

wddgit commented Feb 15, 2024

I will take a look at it.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd7f87/37509/summary.html
COMMIT: 811dafb
CMSSW: CMSSW_14_1_X_2024-02-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43988/37509/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@wddgit
Copy link
Contributor

wddgit commented Feb 16, 2024

+1
Looks good to me.

@makortel
Copy link
Contributor Author

Thanks. In the mean time I found one deficiency that I'm working on to improve right now (if the second argument of the produce-lambda has auto type, the type deduction as written here fails because of ambiguity in the overload).

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43988/38925

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43988/38942

  • This PR adds an extra 28KB to repository

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

Pull request #43988 was updated. @Dr15Jones, @smuzaffar, @makortel can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd7f87/37558/summary.html
COMMIT: bbf6db2
CMSSW: CMSSW_14_1_X_2024-02-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43988/37558/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@makortel
Copy link
Contributor Author

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1cfa1e5 into cms-sw:master Feb 19, 2024
11 checks passed
@makortel makortel deleted the esproducerLambda branch February 20, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants