Tau spring24 update

[Duchstf]

PR description:

This PR is to update some fixes in the Tau NN that was merged in #43639. In particular, the input types were changed to ap_fixed<16,6> which introduced in-consistency in performance in CMSSW as compared to python simulation.

PR validation:

• Codes compiled, and formatted.
• Performance was checked by making various performance plots:

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44349/39386

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @Duchstf for master.

It involves the following packages:

• DataFormats/L1TParticleFlow (l1, upgrade)
• L1Trigger/Phase2L1ParticleFlow (l1, upgrade)

@srimanob, @subirsarkar, @aloeliger, @epalencia, @cmsbuild can you please review it and eventually sign? Thanks.
@missirol, @rovere, @Martin-Grunewald this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[epalencia]

Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44349/39388

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #44349 was updated. @srimanob, @aloeliger, @subirsarkar, @cmsbuild, @epalencia can you please check and sign again.

[epalencia]

Please test

[epalencia]

@Duchstf, could you add the description for this PR?

[aloeliger]

@Duchstf Just another ping on a description for this PR.

[Duchstf]

@aloeliger Hello, the description is identical to the PR referred above, they are the same changes just now propagating to the master branch!

cms-l1t-offline#1214

If you need more detaills let me know, they are identical changes so I didn't write anything else.

[aloeliger]

@Duchstf I don't know if you have been following, however a large bug in using hls4ml code as emulator code has been discovered (#44435). Could you comment on how long it might take you to insert namespaces around the weights and typedefs of the phase 2 NN taus?

[antoniovilela]

@Duchstf @cms-sw/l1-l2
1- Please write a full PR description -- even if you are copying from another repository.
2- Please write meaningful commit messages explaining what is addressed in each commit. You may also squash the commits into a single one [1]. If the squash is done correctly, the PR will not need to be re-signed.
Thanks.
[1]
https://cms-sw.github.io/faq.html#how-do-i-collapse-multiple-commits-into-one
https://git-scm.com/book/en/Git-Tools-Rewriting-History
N.B.
Always create a backup branch.
Check locally before (force-)pushing to the PR branch.

[Duchstf]

@antoniovilela Hello!

Thank you, I wrote the PR description again, and squash the commits, please check. Thanks.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44349/39878

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #44349 was updated. can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d01efb/38720/summary.html
COMMIT: 3c72e74
CMSSW: CMSSW_14_1_X_2024-04-09-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44349/38720/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 24 lines from the logs
• Reco comparison results: 50 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3316263
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3316240
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 1 / 46 workflows

[antoniovilela]

+1

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d01efb/38791/summary.html
COMMIT: 3c72e74
CMSSW: CMSSW_14_1_X_2024-04-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44349/38791/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
546.0 step 2
547.0 step 3
548.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 54 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3316263
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3316234
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 1 / 46 workflows