HCAL: miscellaneous updates for CMT: all depthes for CapIdErrors #44443

zhokin2 · 2024-03-17T16:29:29Z

PR description:

CMT(RMT) code is HCAL certification monitoring tool.
In framework of Remote Monitoring Toot, the CMT was specially designed to
facilitate certification decision on lumi-section(!!!) level.
CMT is not integrated in DQM and is used in parallel with DQM,
in order to have more HCAL information
and for the cross-check of some DQM results

last presentations related CMT:
https://indico.cern.ch/event/1336438/contributions/5625894/attachments/2733639/4762912/zzzhcal762.pdf
https://indico.cern.ch/event/1336703/contributions/5660532/attachments/2757367/4801293/HCAL_DQM_PPD_Workshop_22112023.pdf
https://indico.cern.ch/event/1349428/contributions/5680674/attachments/2765620/4817262/HCAL_DQM_CMS_Week_05122023.pdf

link to CMT twiki:
https://twiki.cern.ch/twiki/bin/viewauth/CMS/HcalRemoteCertificationMonitoring

cms sites related to different tasks of general RMT/CMT code:
https://cms-conddb.cern.ch/eosweb/hcal/HcalRemoteMonitoring/RMT
https://cms-conddb.cern.ch/eosweb/hcal/HcalRemoteMonitoring/CMT
https://cms-conddb.cern.ch/eosweb/hcal/HcalRemoteMonitoring/GlobalRMT
https://cms-conddb.cern.ch/eosweb/hcal/HcalRemoteMonitoring/GlobalPSM
https://cms-conddb.cern.ch/eosweb/hcal/HcalRemoteMonitoring/ALCARECOPSM
https://cms-conddb.cern.ch/eosweb/hcal/HcalRemoteMonitoring/IMPSM

PR validation:

the commands were issued:

scram build code-format
scram b checker
scram build code-checks

cd plugins/
scram b
cd ../macros/cmt/
./compile.csh RemoteMonitoringGLOBAL.cc &
./compile.csh RemoteMonitoringMAP_Global.cc &

results:

.....
scan-build: No bugs found
Deleting: No Diagnostics found
clang-format -i src/DPGAnalysis/HcalTools/macros/cmt/RemoteMonitoringGLOBAL.cc
clang-format -i src/DPGAnalysis/HcalTools/macros/cmt/RemoteMonitoringMAP_Global.cc
clang-format -i src/DPGAnalysis/HcalTools/plugins/CMTRawAnalyzer.cc

Local Products Rules ..... started
Local Products Rules ..... done

…for CapIdErrors involved

cmsbuild · 2024-03-17T16:29:54Z

cms-bot internal usage

cmsbuild · 2024-03-17T16:35:20Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44443/39515

This PR adds an extra 148KB to repository

cmsbuild · 2024-03-17T16:35:41Z

A new Pull Request was created by @zhokin2 for master.

It involves the following packages:

DPGAnalysis/HcalTools (dqm)

@syuvivida, @rvenditti, @tjavaid, @nothingface0, @cmsbuild, @antoniovagnerini can you please review it and eventually sign? Thanks.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

tjavaid · 2024-03-18T00:38:36Z

please test

cmsbuild · 2024-03-18T04:03:42Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6add2d/38204/summary.html
COMMIT: 91afea2
CMSSW: CMSSW_14_1_X_2024-03-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44443/38204/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 94 lines from the logs
Reco comparison results: 45 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3297369
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3297346
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

abdoulline · 2024-03-18T06:24:21Z

You don't need "[14_1_0_pre1]" prefix here, when you're submitting PR to 14_1_X master. This is a default PR submission.
Could you, please, edit the title to remove the prefix?
You will certainly need it [14_0_X] when you'll backport it to the actual data taking CMSSW branch, which is 14_0_X.

abdoulline · 2024-03-18T08:47:22Z

I don't see an explicit check of a new error signature discussed in HCAL (both DPG and OPS) meetings:
all (8) ADC counts (above certain level) are the same in HBHE Digi without having digi.capidError()

zhokin2 · 2024-03-18T08:55:35Z

this is a new problem, and in general, similar problems can happen regularly. What do we call CapIdErrors? This CapIdErrors criterion assumes the inspection of CAPID non-rotation, error and validation bits. Nothing more. A new problem requires special research and effort. Besides, main CMT criterion is based on amplitude estimator, not in CapIdErrors.

…

________________________________________ От: Salavat Abdullin ***@***.***> Отправлено: 18 марта 2024 г. 11:47 Кому: cms-sw/cmssw Копия: Alexandr Zhokin; Mention Тема: Re: [cms-sw/cmssw] HCAL: miscellaneous updates for CMT: all depthes for CapIdErrors (PR #44443) I don't see an explicit check of a new error signature discussed at HCAL meetings: all (8) ADC counts (above certain level) are the same in HBHE Digi without having digi.capidError() — Reply to this email directly, view it on GitHub<#44443 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACHOUBEKCRCV7VBPAZKE54DYY2S3BAVCNFSM6AAAAABE2KXT6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBTGIYTSNBQGY>. You are receiving this because you were mentioned.Message ID: ***@***.***>

abdoulline · 2024-03-18T11:33:59Z

this is a new problem, and in general, similar problems can happen regularly. What do we call CapIdErrors? This CapIdErrors criterion assumes the inspection of CAPID non-rotation, error and validation bits. Nothing more. A new problem requires special research and effort. Besides, main CMT criterion is based on amplitude estimator, not in CapIdErrors.
[…]

OK, let's discuss it later. It's not a prerequisite/showstopper for this update (PR).

tjavaid · 2024-03-20T18:44:44Z

+1

@zhokin2 , could you please update the description with some useful documentation on CMT (probably the twiki ?) and/or related presentation? Thanks!

cmsbuild · 2024-03-20T18:45:06Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-03-20T20:05:45Z

@zhokin2 @tjavaid
Could you clean up the commented code, and not introduce new commented code?
Thanks.

zhokin2 · 2024-03-22T07:17:28Z

all the mentioned comments in these files removed

zhokin2 · 2024-03-22T07:20:40Z

Done

________________________________________ От: antoniovilela ***@***.***> Отправлено: 22 марта 2024 г. 03:22 Кому: cms-sw/cmssw Копия: Alexandr Zhokin; Mention Тема: Re: [cms-sw/cmssw] HCAL: miscellaneous updates for CMT: all depthes for CapIdErrors (PR #44443) @antoniovilela commented on this pull request.

________________________________ In DPGAnalysis/HcalTools/scripts/cmt/mkcfg222_new120.csh<#44443 (comment)>:

+set kk=1

+cat a.py.beg > PYTHON_${1}/Reco_${jj}_${kk}_cfg.py +set nn=0 + +foreach i (`cat TXT_${1}/run_${jj}`) +@ nn = ${nn} + "1" +echo "nn= ${nn} , i= ${i}, kk= ${kk}" + +#if( ${nn} < "120" ) then +#if( ${nn} < "50" ) then +#if( ${nn} < "30" ) then +#if( ${nn} < "3" ) then + +#if( ${nn} < "1" ) then +if( ${nn} < "2" ) then +#if( ${nn} < "3" ) then Remove commented out code. — Reply to this email directly, view it on GitHub<#44443 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACHOUBFKWDXSWAJTDK7HOILYZN2UVAVCNFSM6AAAAABE2KXT6WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNJTG4YTQOJZGI>. You are receiving this because you were mentioned.Message ID: ***@***.***>

cmsbuild · 2024-03-22T07:24:00Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44443/39625

This PR adds an extra 24KB to repository

cmsbuild · 2024-03-22T07:24:25Z

Pull request #44443 was updated. @tjavaid, @cmsbuild, @syuvivida, @nothingface0, @antoniovagnerini, @rvenditti can you please check and sign again.

tjavaid · 2024-03-23T04:42:20Z

please test

cmsbuild · 2024-03-23T08:41:27Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6add2d/38359/summary.html
COMMIT: 8fa3bf5
CMSSW: CMSSW_14_1_X_2024-03-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44443/38359/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 6 lines from the logs
Reco comparison results: 42 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3297537
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3297514
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

tjavaid · 2024-03-25T07:41:17Z

+1

cmsbuild · 2024-03-25T07:41:44Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-03-25T10:13:27Z

+1

[CMSSW_14_1_0_pre1] HCAL: miscellaneous updates for CMT: all depthes …

91afea2

…for CapIdErrors involved

cmsbuild added this to the CMSSW_14_1_X milestone Mar 17, 2024

cmsbuild added dqm-pending pending-signatures tests-pending orp-pending code-checks-pending labels Mar 17, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 17, 2024

cmsbuild added tests-started and removed tests-pending labels Mar 18, 2024

cmsbuild added tests-approved and removed tests-started labels Mar 18, 2024

zhokin2 changed the title ~~[CMSSW_14_1_0_pre1] HCAL: miscellaneous updates for CMT: all depthes for CapIdErrors~~ HCAL: miscellaneous updates for CMT: all depthes for CapIdErrors Mar 18, 2024

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Mar 20, 2024

cmsbuild added dqm-pending pending-signatures tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Mar 22, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 22, 2024

cmsbuild added tests-started and removed tests-pending labels Mar 23, 2024

cmsbuild added tests-approved and removed tests-started labels Mar 23, 2024

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Mar 25, 2024

cmsbuild added orp-approved and removed orp-pending labels Mar 25, 2024

cmsbuild merged commit 995d038 into cms-sw:master Mar 25, 2024
11 checks passed

This was referenced Mar 25, 2024

[CPP20] Cleanup BuildFile.xml for Alignment/OfflineValidation #44538

Merged

AXOL1TL emulator update for L1 Menu parsing with UTMv12 #44510

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HCAL: miscellaneous updates for CMT: all depthes for CapIdErrors #44443

HCAL: miscellaneous updates for CMT: all depthes for CapIdErrors #44443

zhokin2 commented Mar 17, 2024 •

edited

Loading

cmsbuild commented Mar 17, 2024 •

edited

Loading

cmsbuild commented Mar 17, 2024

cmsbuild commented Mar 17, 2024

tjavaid commented Mar 18, 2024

cmsbuild commented Mar 18, 2024

abdoulline commented Mar 18, 2024 •

edited

Loading

abdoulline commented Mar 18, 2024 •

edited

Loading

zhokin2 commented Mar 18, 2024 via email

abdoulline commented Mar 18, 2024 •

edited

Loading

tjavaid commented Mar 20, 2024

cmsbuild commented Mar 20, 2024

antoniovilela commented Mar 20, 2024

zhokin2 commented Mar 22, 2024

zhokin2 commented Mar 22, 2024 via email

cmsbuild commented Mar 22, 2024

cmsbuild commented Mar 22, 2024

tjavaid commented Mar 23, 2024

cmsbuild commented Mar 23, 2024

tjavaid commented Mar 25, 2024

cmsbuild commented Mar 25, 2024

antoniovilela commented Mar 25, 2024

HCAL: miscellaneous updates for CMT: all depthes for CapIdErrors #44443

HCAL: miscellaneous updates for CMT: all depthes for CapIdErrors #44443

Conversation

zhokin2 commented Mar 17, 2024 • edited Loading

PR description:

PR validation:

the commands were issued:

results:

cmsbuild commented Mar 17, 2024 • edited Loading

cmsbuild commented Mar 17, 2024

cmsbuild commented Mar 17, 2024

tjavaid commented Mar 18, 2024

cmsbuild commented Mar 18, 2024

Comparison Summary

abdoulline commented Mar 18, 2024 • edited Loading

abdoulline commented Mar 18, 2024 • edited Loading

zhokin2 commented Mar 18, 2024 via email

abdoulline commented Mar 18, 2024 • edited Loading

tjavaid commented Mar 20, 2024

cmsbuild commented Mar 20, 2024

antoniovilela commented Mar 20, 2024

zhokin2 commented Mar 22, 2024

zhokin2 commented Mar 22, 2024 via email

cmsbuild commented Mar 22, 2024

cmsbuild commented Mar 22, 2024

tjavaid commented Mar 23, 2024

cmsbuild commented Mar 23, 2024

Comparison Summary

tjavaid commented Mar 25, 2024

cmsbuild commented Mar 25, 2024

antoniovilela commented Mar 25, 2024

zhokin2 commented Mar 17, 2024 •

edited

Loading

cmsbuild commented Mar 17, 2024 •

edited

Loading

abdoulline commented Mar 18, 2024 •

edited

Loading

abdoulline commented Mar 18, 2024 •

edited

Loading

abdoulline commented Mar 18, 2024 •

edited

Loading